-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add method to compute the length of a tree-decomposition #36705
Merged
vbraun
merged 6 commits into
sagemath:develop
from
dcoudert:graphs/length_of_tree_decomposition
Dec 10, 2023
Merged
add method to compute the length of a tree-decomposition #36705
vbraun
merged 6 commits into
sagemath:develop
from
dcoudert:graphs/length_of_tree_decomposition
Dec 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23f6715
to
e349b00
Compare
2334b6e
to
08939a8
Compare
kwankyu
reviewed
Nov 23, 2023
kwankyu
reviewed
Nov 23, 2023
The macro looks good in the documentation preview. |
Documentation preview for this PR (built with commit 7fcc517; changes) is ready! 🎉 |
kwankyu
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM.
Thank you. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 7, 2023
…ition Given a graph `G` and a tree-decomposition `T` of `G`, the _length_ of the tree-decomposition `T` is the maximum _diameter_ in `G` of its bags, where the diameter of a bag `X_i` is the largest distance in `G` between the vertices in `X_i`. We add a method to compute the _length_ of a given tree-decomposition of a graph. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36705 Reported by: David Coudert Reviewer(s): David Coudert, Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a graph
G
and a tree-decompositionT
ofG
, the length of the tree-decompositionT
is the maximum diameter inG
of its bags, where the diameter of a bagX_i
is the largest distance inG
between the vertices inX_i
.We add a method to compute the length of a given tree-decomposition of a graph.
📝 Checklist
⌛ Dependencies