-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement Bröker's algorithm for constructing supersingular curves #36665
Merged
The head ref may contain hidden characters: "public/br\u00F6ker"
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnCremona
reviewed
Nov 16, 2023
JohnCremona
reviewed
Nov 16, 2023
I amde a couple of comments, not in a formal review (yet). |
71e7ca5
to
2d6b854
Compare
JohnCremona
approved these changes
Nov 22, 2023
Thank you! |
pdf docs fail
|
Documentation preview for this PR (built with commit 1e06b22; changes) is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this patch, we add a function$\mathbb F_p$ having a small-degree endomorphism which anticommutes with Frobenius. The function optionally constructs and returns the endomorphism as an explicit isogeny; this should prove useful later when we have better tools for endomorphism rings.
special_supersingular_curve()
to construct a supersingular elliptic curve defined over a givenBröker's algorithm is both the standard approach for finding a supersingular elliptic curve in given characteristic, as well as part of the setup for several algorithms dealing with endomorphism rings: The special endomorphism together with Frobenius forms a generating set of the endomorphism algebra.
Cc: @JohnCremona @defeo @GiacomoPope @remyoudompheng