Yet more spkg_configure for standard python packages #36276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see sagemath#35658, in particular sagemath#35658 (comment) and later
dimpase
force-pushed
the
yet_more_spkg_conf_for_python
branch
from
83ea32e to
97ca5cb
Compare
Member
Author
|
|
Member
Author
|
Tested on Debian oldstable with pyenv-installed Python 3.11.5. Configured as I had to deviate from version constraint on Output of |
The pytz package is a dependency of three others: babel, rpy2, and tzlocal. And tzlocal is itself a dependency of rpy2. Babel is already disabled with --disable-doc, and rpy2 and tzlocal are disabled with --disable-r. It therefore makes sense to disable pytz when both --disable-doc and --disable-r are given.
The pycparser package is a dependency of two others, cffi and rpy2, which can be disabled with --disable-notebook and --disable-r respectively. As a result we can disable pycparser when both flags are present.
The pytz_deprecation_shim package is a dependency only of tzlocal, which is already disabled with --disable-r.
Passing --disable-notebook to ./configure already disables the argon2_cffi package, so it should be safe to disable its bindings as well.
The soupsieve package is a dependency of beautifulsoup4, which is already disabled with --disable-notebook. It should therefore be safe to disable soupsieve under the same circumstances.
The sphinx_basic_ng package is solely a dependency of furo, which is already disabled with --disable-doc. We should therefore disable sphinx_basic_ng with --disable-doc as well.
The fastjsonschema package is solely a dependency of nbformat, which is already disabled with --disable-notebook. We should therefore disable fastjsonschema with --disable-notebook as well.
Member
Author
|
@mkoeppe - I already mentioned this issue in #36256 - |
Contributor
|
this would need repro - #32531 |
mkoeppe
approved these changes
Sep 19, 2023
…yet_more_spkg_conf_for_python
Member
Author
|
In particular, one needs fresh furo to go with fresh sphinx, otherwise docs don't build (build still finishes without a fatal error, but no html gets generated). |
dimpase
force-pushed
the
yet_more_spkg_conf_for_python
branch
from
938a8cd to
fb2752a
Compare
Member
Author
|
Is there anything to do here, still? I'm taking the liberty to turn this to positive review. |
Contributor
|
It's in good enough shape for this experimental feature, so I agree with the positive review. On The other tested platforms look OK (despite the scary red) |
Contributor
|
Is that |
Member
|
merge conflict |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 23, 2023
sagemathgh-36296: remove duplicate args in @options() in region_plot This is needed for Sphinx 7.1+, as outlined in sagemath#36295 and discovered in sagemath#36276 This will resolve sagemath#36295 It also fixes a bug in `region_plot`, where in some cases `plot_points` were not passed to the backend. URL: sagemath#36296 Reported by: Dima Pasechnik Reviewer(s): Dima Pasechnik, Kwankyu Lee, Michael Orlitzky
Contributor
removed in 180e814 |
|
Documentation preview for this PR (built with commit 180e814; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 25, 2023
sagemathgh-36276: Yet more spkg_configure for standard python packages This is a continuation of sagemath#36256 - Fixes sagemath#36301 - Fixes https://groups.google.com/g/sage- release/c/1wOBmhvNJqc/m/Jk14VAbjBAAJ (hence marked critical) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies - sagemath#36296: to use an up to date Sphinx - sagemath#36267: updated ipympl, etc Also, a Jupyter/Python issue was uncovered there, which might need work. URL: sagemath#36276 Reported by: Dima Pasechnik Reviewer(s): Matthias Köppe, Michael Orlitzky
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 27, 2023
sagemathgh-36338: CI: Merge open blocker PRs in all CI workflows + other improvements <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> The new script `.ci/merge-fixes.sh` uses the GitHub CLI to retrieve open PRs with the "blocker" label from sagemath/sage and tries to merge them into the tested branch, ignoring any PRs that give merge failures. We call this script in all CI workflows. Thus, - hotfixes for the linter (such as sagemath#36327) or - fixes for build problems (such as sagemath#36276) will take effect in the CI workflows of all PRs. This can be seen in the runs of the workflows of the present PR (section "Merge CI fixes from sagemath/sage"). Additionally, - we fix `debian-trixie`, which failed because a system package is no longer available - we fix `macos-conda-maximal` by removing some fictitious distros/conda.txt files - we refactor ci-macos using a new reusable workflow; example runs: - https://github.com/mkoeppe/sage/actions/runs/6308124398 - https://github.com/sagemath/cysignals/actions/runs/6316714387?pr=185 - we update the ci-macos platforms, including a configuration for the new and problematic Xcode 15.0 <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36338 Reported by: Matthias Köppe Reviewer(s): Dima Pasechnik, Jonathan Kliem, Kwankyu Lee, Matthias Köppe, Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 17, 2023
sagemathgh-36332: Yet more more spkgs confs a continuation of sagemath#36276 (more system Python packages support via `--enable-system-site-packages`) Also, added a Cython 3.0.2 patch to fix the usage of `--enable-system- site-packages` option. Without it, and sufficiently many Python system packages, sagelib won't build. (Therefore, blocker label added) URL: sagemath#36332 Reported by: Dima Pasechnik Reviewer(s): Michael Orlitzky
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 19, 2023
sagemathgh-36332: Yet more more spkgs confs a continuation of sagemath#36276 (more system Python packages support via `--enable-system-site-packages`) Also, added a Cython 3.0.2 patch to fix the usage of `--enable-system- site-packages` option. Without it, and sufficiently many Python system packages, sagelib won't build. (Therefore, blocker label added) URL: sagemath#36332 Reported by: Dima Pasechnik Reviewer(s): Michael Orlitzky
oscarbenjamin
pushed a commit
to oscarbenjamin/sympy
that referenced
this pull request
Nov 3, 2023
clrpackages
pushed a commit
to clearlinux-pkgs/sympy
that referenced
this pull request
Jun 6, 2024
Jerry James (1):
Remove unused keyword arguments to ast types
Matthias Köppe (4):
CI: Update ci-sage.yml
CI: Update ci-sage.yml to use debian-bullseye (Python 3.9)
CI: Update ci-sage.yml to use sagemath/sage#36276
.github/workflows/ci-sage.yml: Back to using sagemath/sage @ develop
Oscar Benjamin (55):
maint: bump version to 1.12.1
Add noqa for flake8
Add noqa
doc: fix dangling hyphens per sphinx-lint
Update pyversion check in optdep tests
Fix .mailmap
Update versions for optional dependency jobs in CI
Update AUTHORS file
fix(docs): fix broken sphinx references
maint: update for new asv
Install mpmath in optdep tests
fix(core): various fixes for latest mpmath changes
Don't install libclang in optdep tests
Add more Python versions to test install
Use 3.13-dev in release.yml
Pin asv==0.5.1
Temporarily run sage ci in PRs
Only run SAGE CI on merge
Chage version to 1.12.1a1
Update release in CI
maint(ci): add a numpy prerelease job to CI
rename jobs
Fix parsing and printing of numpy types for numpy 2.0
Add requirements-dev.txt
Add requiremennts-dev.txt to whitelist
Fix version check for SciPy prereleases
Fix scipy version check
maint(ci): add CI tests for mpmath master branch
fix python version
Fix yml syntax
maint(ci): make mpmath CI job run after main tests
fix(core): don't use mpmath's to_pickable for pickling
Fix GA workflow
Configure graphviz
release: push to PyPI on tag push
Fix actions versions
Add job to push to PYPI on tag push
Fix duplicate jo ame
Add comment
Restrict workflow to sympy-1.12.* tags
release: Automate GitHub release and docs update
Fix workflow
Bump version in release.py
release: use GH_TOKENN for GitHub release
release: use ssh key instead of token
maint(deps): require mpmath >= 1.1.0, < 1.4.0
maint(release): bump version to 1.12.1
remove unneeded f-string
release: reenable pusing to PyPI
release: don't make a draft github release
release: bump version to 1.12.1
release: Use ${{}} in release.yml
Use github.env...
maint: update .mailmap and AUTHORS
maint: update actions versions in CI
Pablo Galindo Salgado (1):
Fix factorial parsing for Python 3.12
Raj Sapale (2):
Changed the signature methods for _array_ methods in Sympy to :
author: add Raj Sapale to .mailmap
S.Y. Lee (6):
Fix deprecation issues with python 3.12 ast lib
Replace ast.Num
Fix additional deprecation warnings
Use pypy 2.7
Fix deprecated bitwise not on boolean and fix pytest return warning
Remove semantically wrong test
Sam Lubelsky (6):
Added test cases for the new __array__ methods(Copy=true/false/None)
fixed trailing whitespace
actually fixed trailing whitespace
now imports skip properly.
added numpy version checks to determine if copy=False should be tested
fixed trailing whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #36256
📝 Checklist
⌛ Dependencies
ipympl/pkgconfig/widgetsnbextensionto wheel packages, drop build deps #36267: updated ipympl, etcAlso, a Jupyter/Python issue was uncovered there, which might need work.