Skip to content

Run pytest for src tree if no filename is given #35999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbraun merged 6 commits into from
Aug 5, 2023
Merged

Run pytest for src tree if no filename is given #35999

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5a42152
Do not run pytest without filenames
kwankyu Jul 29, 2023
a61da7f
No filenamrs is equivalent to src/sage
kwankyu Jul 29, 2023
2af5fdb
Use src not src/sage
kwankyu Jul 29, 2023
fe2d841
Merge branch 'develop' into p/fix-pytest-error
kwankyu Jul 30, 2023
8326140
Use previously declared SAGE_SRC
kwankyu Aug 2, 2023
e17f1de
Merge branch 'p/fix-pytest-error' of https://github.com/kwankyu/sage …
kwankyu Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions src/bin/sage-runtests
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,13 +175,18 @@ if __name__ == "__main__":
pytest_options = []
if args.verbose:
pytest_options.append("-v")
# #31924: Do not run pytest on individual Python files unless
# they match the pytest file pattern. However, pass names
# of directories. We use 'not os.path.isfile(f)' for this so that
# we do not silently hide typos.
filenames = [f for f in args.filenames
if f.endswith("_test.py") or not os.path.isfile(f)]
if filenames or not args.filenames:

# #35999: no filename in arguments defaults to "src"
if not args.filenames:
filenames = [SAGE_SRC]
else:
# #31924: Do not run pytest on individual Python files unless
# they match the pytest file pattern. However, pass names
# of directories. We use 'not os.path.isfile(f)' for this so that
# we do not silently hide typos.
filenames = [f for f in args.filenames
if f.endswith("_test.py") or not os.path.isfile(f)]
if filenames:
print(f"Running pytest on {filenames} with options {pytest_options}")
exit_code_pytest = pytest.main(filenames + pytest_options)
if exit_code_pytest == 5:
Expand Down