Skip to content

Conversation

@pjbruin
Copy link
Contributor

@pjbruin pjbruin commented Feb 28, 2023

Fixes #35216

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: a2929b0

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 87.50% and project coverage change: +0.01 🎉

Comparison is base (52a81cb) 88.57% compared to head (a2929b0) 88.58%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35218      +/-   ##
===========================================
+ Coverage    88.57%   88.58%   +0.01%     
===========================================
  Files         2140     2140              
  Lines       397273   397273              
===========================================
+ Hits        351891   351940      +49     
+ Misses       45382    45333      -49     
Impacted Files Coverage Δ
src/sage/groups/abelian_gps/element_base.py 97.36% <87.50%> (ø)
...e/combinat/cluster_algebra_quiver/mutation_type.py 48.21% <0.00%> (-3.92%) ⬇️
src/sage/modular/local_comp/liftings.py 98.33% <0.00%> (-1.67%) ⬇️
src/sage/cpython/_py2_random.py 75.20% <0.00%> (-1.24%) ⬇️
src/sage/quadratic_forms/binary_qf.py 92.03% <0.00%> (-0.75%) ⬇️
src/sage/groups/generic.py 88.34% <0.00%> (-0.68%) ⬇️
src/sage/modular/modform/numerical.py 94.19% <0.00%> (-0.65%) ⬇️
...sage/geometry/hyperbolic_space/hyperbolic_model.py 88.95% <0.00%> (-0.62%) ⬇️
src/sage/doctest/forker.py 80.24% <0.00%> (-0.54%) ⬇️
src/sage/doctest/reporting.py 74.45% <0.00%> (-0.44%) ⬇️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@alexjbest alexjbest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjbruin
Copy link
Contributor Author

pjbruin commented Mar 1, 2023

lgtm

Thanks!

@vbraun vbraun merged commit f7e36b4 into sagemath:develop Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AbelianGroupElement does not always reduce exponent vectors when needed

5 participants