animate ignores options to show that are passed up from the plot command

[jasongrout]

This animate command shouldn't ignore the options to show() that are passed through by the plot command (here the options are ymin and ymax):

sage: var('t')
sage: damped_oscillator = 41/311*sqrt(311)*e^(-3/8*t)*sin(1/8*sqrt(311)*t) + 3*e^(-3/8*t)*cos(1/8*sqrt(311)*t)
sage: animate([plot( lambda x: damped_oscillator( t = x + k ), -1/2, 3*pi, ymin=-2, ymax=3.5 ) for k in srange( 0, pi, 0.3 ) ]).show()

Thanks to Johann Myrkraverk Oskarsson for reporting this.

CC: @sagetrac-wcauchois

Component: graphics

Author: Jason Grout, Andrey Novoseltsev

Reviewer: Tim Dumol, Marshall Hampton, Karl-Dieter Crisman

Merged: sage-4.6.2.alpha2

Issue created by migration from https://trac.sagemath.org/ticket/7981

[jasongrout]

comment:1

Attachment: trac-7981-show_options.patch.gz

[jasongrout]

Author: Jason Grout

[jasongrout]

comment:4

Bill and Karl-Dieter,

You two might be interested in this. Karl-Dieter, you wrote the original code that passed show options around, I believe. I just made the consolidation happen in .save() instead of .show().

[jasongrout]

comment:5

This fixes #7524.

[kcrisman]

comment:6

Umm... I find that unlikely, though I may have broken something inadvertently.

[TimDumol]

comment:7

Doctesting on plot.py results in 2 errors:

{{[
sage -t "devel/sage-ref/sage/plot/plot.py"
--leak-resolution=high --log-socket=127.0.0.1 --leak-check=full --num-callers=25 --suppressions=/opt/sage-4.3.rc0.O0/local/lib/valgrind/sage.supp

---

File "/home/timdumol/sage-4.3.1.alpha0/devel/sage-ref/sage/plot/plot.py", line 1925:
sage: c.show(figsize=[5,5], xmin=-1, xmax=3, ymin=-1, ymax=3) sage: point((-1,1),pointsize=30, color='red')
Exception raised:
Traceback (most recent call last):
File "/home/timdumol/sage-4.3.1.alpha0/local/bin/ncadoctest.py", line 1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File "/home/timdumol/sage-4.3.1.alpha0/local/bin/sagedoctest.py", line 38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
File "/home/timdumol/sage-4.3.1.alpha0/local/bin/ncadoctest.py", line 1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest main.example_37[5]>", line 1
c.show(figsize=[Integer(5),Integer(5)], xmin=-Integer(1), xmax=Integer(3), ymin=-Integer(1), ymax=Integer(3)) sage: point((-Integer(1),Integer(1)),pointsize=Integer(30), color='red')###line 1925:
sage: c.show(figsize=[5,5], xmin=-1, xmax=3, ymin=-1, ymax=3) sage: point((-1,1),pointsize=30, color='red')
^
SyntaxError: invalid syntax

---

File "/home/timdumol/sage-4.3.1.alpha0/devel/sage-ref/sage/plot/plot.py", line 1930:
sage: c.save(DOCTEST_MODE_FILE)
Exception raised:
Traceback (most recent call last):
File "/home/timdumol/sage-4.3.1.alpha0/local/bin/ncadoctest.py", line 1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File "/home/timdumol/sage-4.3.1.alpha0/local/bin/sagedoctest.py", line 38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
File "/home/timdumol/sage-4.3.1.alpha0/local/bin/ncadoctest.py", line 1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest main.example_37[7]>", line 1, in
c.save(DOCTEST_MODE_FILE)###line 1930:
sage: c.save(DOCTEST_MODE_FILE)
NameError: name 'DOCTEST_MODE_FILE' is not defined

---

1 items had failures:
2 of 8 in main.example_37
}}}

[TimDumol]

Reviewer: Tim Dumol