save_notebook is called twice on notebook shutdown

[qed777]

See run_notebook.py's run_twisted, which generates DOT_SAGE/sagen_notebook.sagenb/twistedconf.tac.

Mentioned here.

Component: notebook

Author: Alex Leone

Reviewer: Tim Dumol

Merged: sagenb-0.6

Issue created by migration from https://trac.sagemath.org/ticket/7801

[sagetrac-acleone]

Attachment: trac_7801-save_notebook_twice.patch.gz

Fixed interrupt handler to stop the twisted server instead of in save_notebook

[sagetrac-acleone]

comment:1

What the problem was:
The signal handler would call save_notebook(), which would stop the twisted server. There was a handler on the server shutdown, "reactor.addSystemEventTrigger('before', 'shutdown', save_notebook)", that would call save_notebook() again.

Changes:
Moved the code that stops the server into the signal handler, and removed the save_notebook call.

[TimDumol]

Author: Alex Leone

[TimDumol]

comment:2

LGTM. Nice job.

[TimDumol]

Reviewer: Tim Dumol

[TimDumol]

Merged: sagenb-0.6