manually removing executable bits doesn't work

[sagetrac-mvngu]

This is a follow up to #3687. Apparently, the issue of executable bits pop up again after they had been manually removed. That is, manually remove the executable bits of sage-banner, sage-gdb-commands, sage-maxima.lisp, and sage-verify-pyc. Then create a source distribution and you see those executable bits restored:

[mvngu@sage bin]$ pwd
/home/mvngu/release/sage-4.1.1.alpha1/local/bin
[mvngu@sage bin]$ hg st
M sage-README-osx.txt
M sage-banner
M sage-gdb-commands
M sage-maxima.lisp
M sage-verify-pyc

Somewhere a script called by the command

sage -sdist <version-number>

is restoring those executable bits.

Component: misc

Author: Willem Jan Palenstijn

Reviewer: Minh Van Nguyen

Merged: sage-4.3.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/6625

[wjp]

comment:1

Attachment: scripts_6625_no_x_bit.patch.gz

The sage-make_devel_packages explicitly set the x bit on all sage-* files.

[sagetrac-mvngu]

Attachment: trac_6625-no-x-bit.patch.gz

rebased against Sage 4.3.1.rc1; apply to SAGE_LOCAL/bin

[sagetrac-mvngu]

Author: Willem Jan Palenstijn

[sagetrac-mvngu]

Reviewer: Minh Van Nguyen

[sagetrac-mvngu]

comment:2

The attachment scripts_6625_no_x_bit.patch fails to apply against Sage 4.3.1.rc1:

[mvngu@mod bin]$ pwd
/dev/shm/mvngu/sage-4.3.1.rc1/local/bin
[mvngu@mod bin]$ hg qimport https://github.com/sagemath/sage-prod/files/10645701/scripts_6625_no_x_bit.patch.gz
adding scripts_6625_no_x_bit.patch to series file
[mvngu@mod bin]$ hg qpush
applying scripts_6625_no_x_bit.patch
patching file sage-make_devel_packages
Hunk #1 FAILED at 135
1 out of 1 hunks FAILED -- saving rejects to file sage-make_devel_packages.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh scripts_6625_no_x_bit.patch
[mvngu@mod bin]$ cat sage-make_devel_packages.rej 
--- sage-make_devel_packages
+++ sage-make_devel_packages
@@ -136,6 +136,8 @@
 rm -rf $SCRIPTS
 mkdir $SCRIPTS
 chmod +x sage-*
+chmod -x sage-README-osx.txt sage-banner sage-gdb-commands
+chmod -x sage-maxima.lisp sage-verify-pyc
 chmod +x dsage_*
 rm sage-*~

The failure results from #7975, which removes dsage from Sage and the patches on #7975 have been merged in Sage 4.3.1.rc1. The guilty line from scripts_6625_no_x_bit.patch is:

139	141	chmod +x dsage_*

Essentially the patch looks good. I have rebased it against Sage 4.3.1.rc1, so only my rebase trac_6625-no-x-bit.patch needs reviewing.

[wjp]

comment:3

Thanks. The rebase looks good to me.

[sagetrac-mvngu]

Merged: sage-4.3.2.alpha0

[sagetrac-mvngu]

comment:4

Merged trac_6625-no-x-bit.patch in the script repository.