Make openssl an optional dependency of python3

[mkoeppe]

As discussed in #30556, if openssl is enabled using --enable-openssl and neither openssl nor python3 are available as system packages, this makes sure that openssl is built before python3.

If system openssl is found via #30557, then --enable-openssl does NOT trigger building openssl. Use --enable-openssl --without-system-openssl if this is desired.

Part of #21700 Meta-ticket: Declare "optional" dependencies of packages (a package manager's suggested/recommended packages)

CC: @mwageringel @slel @dimpase @orlitzky @jhpalmieri

Component: build

Author: Matthias Koeppe

Branch/Commit: 0c394ca

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/30560

[mkoeppe]

comment:2

Best done with a change to the SAGE_SPKG_ENABLE macro

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,3 +1,5 @@
 As discussed in #30556, if `openssl` is enabled using `--enable-openssl` and neither `openssl` nor `python3` are available as system packages, this makes sure that `openssl` is built before `python3`.
 
+If system openssl is found via #30557, then `--enable-openssl` does not trigger building openssl. Use `--enable-openssl --without-system-openssl` if this is desired.
 
+

[mkoeppe]

Branch: u/mkoeppe/build_optional_package_openssl_as_part_of_sage_toolchain

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Commit: 0c394ca

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,5 +1,5 @@
 As discussed in #30556, if `openssl` is enabled using `--enable-openssl` and neither `openssl` nor `python3` are available as system packages, this makes sure that `openssl` is built before `python3`.
 
-If system openssl is found via #30557, then `--enable-openssl` does not trigger building openssl. Use `--enable-openssl --without-system-openssl` if this is desired.
+If system openssl is found via #30557, then `--enable-openssl` does NOT trigger building openssl. Use `--enable-openssl --without-system-openssl` if this is desired.
 
 

[mkoeppe]

comment:6

Found a simpler solution than the previously discussed SAGE_TOOLCHAIN business. Needs review

---

New commits:

0c394ca

build/pkgs/python3/dependencies: Make openssl a dependency if it is enabled

[mkoeppe]

Description changed:

--- 
+++ 
@@ -2,4 +2,5 @@
 
 If system openssl is found via #30557, then `--enable-openssl` does NOT trigger building openssl. Use `--enable-openssl --without-system-openssl` if this is desired.
 
+Part of #21700 Meta-ticket: Declare "optional" dependencies of packages (a package manager's suggested/recommended packages)
 

[jhpalmieri]

comment:9

This looks like it works, and the change makes sense. I couldn't completely test, though, since the ssl module for Python always seems to get built.

To test, I did make distclean. Then

$ ./configure --enable-openssl --with-system-python3=no
$ make

built openssl first and then python3, which is the point, right? Without this branch, these commands just build python3, not openssl.

Do I need to find a system on which Python's ssl module fails to build?

[mkoeppe]

comment:10

Replying to @jhpalmieri:

To test, I did make distclean. Then

$ ./configure --enable-openssl --with-system-python3=no
$ make

built openssl first and then python3, which is the point, right?

Right.

Without this branch, these commands just build python3, not openssl.

I think without this branch it should also have built openssl, just not necessarily before python3.

[mkoeppe]

comment:11

Replying to @jhpalmieri:

Do I need to find a system on which Python's ssl module fails to build?

I don't think that's necessary

[jhpalmieri]

comment:12

Replying to @mkoeppe:

Replying to @jhpalmieri:

To test, I did make distclean. Then

$ ./configure --enable-openssl --with-system-python3=no
$ make

built openssl first and then python3, which is the point, right?

Right.

Without this branch, these commands just build python3, not openssl.

I think without this branch it should also have built openssl, just not necessarily before python3.

Sorry. I actually ran make python3, which is pretty convincing evidence that with this branch and with ./configure --enable-openssl, Sage believes that openssl is a dependency of python3.

[jhpalmieri]

Reviewer: John Palmieri

[jhpalmieri]

comment:13

Good find with findstring, by the way.