Standardize `intersection` in `combinatorial_polyhedron/bit_vector_operations.cc`

[kliem]

We standardize the arguments of the intersection to be

inline void intersection(uint64_t *dest uint64_t *A uint64_t *B, size_t face_length)

corresponding well with C[i] = A[i] & B[i] (and with src/sage/data_structures/bitset.pxi).

Previously it was

inline void intersection(uint64_t *A, uint64_t *B, uint64_t *C, size_t face_length)

This is confusing, once you get used to the standard way of doing it (gmp also has mpz_add(mpz_t dest, const mpz_t src1, const mpz_t src2))

CC: @jplab @LaisRast @tscrim

Component: geometry

Author: Jonathan Kliem

Branch/Commit: fe880a4

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/30429

[kliem]

Description changed:

--- 
+++ 
@@ -4,7 +4,7 @@
 inline void intersection(uint64_t *dest, const uint64_t *A, const uint64_t *B, size_t face_length)
 ```
 
-corresponding well with `C[i] = A[i] & B[i]` (and with `src/sage/data_structures/bitset.pxi`.
+corresponding well with `C[i] = A[i] & B[i]` (and with `src/sage/data_structures/bitset.pxi`).
 
 Also we add some `const` declarations for other functions.
 

[kliem]

Description changed:

--- 
+++ 
@@ -1,12 +1,10 @@
 We standardize the arguments of the intersection to be
 
 ```
-inline void intersection(uint64_t *dest, const uint64_t *A, const uint64_t *B, size_t face_length)
+inline void intersection(uint64_t *dest uint64_t *A uint64_t *B, size_t face_length)
 ```
 
 corresponding well with `C[i] = A[i] & B[i]` (and with `src/sage/data_structures/bitset.pxi`).
-
-Also we add some `const` declarations for other functions.
 
 Previously it was
 

[kliem]

New commits:

fe880a4

input of `intersection` in standard order

[kliem]

Commit: fe880a4

[kliem]

Branch: public/30429

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:6

LGTM.

[kliem]

comment:7

Thank you.