sage.tensor.modules.free_module_basis: Add testsuite

[mkoeppe]

We add a _test... method to Basis_abstract and run the test suite for some instances of FreeModuleBasis, FreeModuleCoBasis.

CC: @mjungmath @egourgoulhon @tscrim

Component: linear algebra

Author: Matthias Koeppe

Branch/Commit: f1f67d3

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/30287

[mkoeppe]

Branch: u/mkoeppe/sage_tensor_modules_free_module_basis__add_testsuite

[mkoeppe]

comment:2

The tests currently fail:

File "src/sage/tensor/modules/free_module_basis.py", line 388, in sage.tensor.modules.free_module_basis.FreeModuleCoBasis
Failed example:
    TestSuite(f).run()
...
    IndexError: index out of range: 0 not in [1, 3]
    ------------------------------------------------------------
    The following tests failed: _test_iter_len

File "src/sage/tensor/modules/free_module_basis.py", line 400, in sage.tensor.modules.free_module_basis.FreeModuleCoBasis.?
Failed example:
    TestSuite(f).run()
...
      File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-algebraic-2018-spring/local/lib/python3.7/site-packages/sage/tensor/modules/free_module_basis.py", line 98, in _test_iter_len
        tester.assertTrue(x in self.free_module())
      File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", line 705, in assertTrue
        raise self.failureException(msg)
    AssertionError: False is not true
    ------------------------------------------------------------
    The following tests failed: _test_iter_len

---

New commits:

1e69c0e

sage.tensor.modules.free_module_basis.Basis_abstract: Add _test_iter_len

[mkoeppe]

Commit: 1e69c0e

[mkoeppe]

comment:3

Should the method FreeModuleCoBasis.free_module really return the (primal) base module, as it currently does? Or rather the dual of it?

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

f1f67d3

FreeModuleCoBasis: Add _test_iter_len

[sagetrac-git]

Changed commit from 1e69c0e to f1f67d3

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,2 +1,2 @@
-We add `_test...` methods to `Basis_abstract` and run the test suite for some instances of `FreeModuleBasis`, `FreeModuleCoBasis`.
+We add a `_test...` method to `Basis_abstract` and run the test suite for some instances of `FreeModuleBasis`, `FreeModuleCoBasis`.
 

[tscrim]

comment:7

While there is a bit of ambiguity, considering the output:

sage: f
Dual basis (e^0,e^1,e^2) on the Rank-3 free module M over the Integer Ring

which is saying that it is a dual basis of M, I think it is fair that free_module returns the base module rather than its dual. As such, I am setting this to a positive review.

[tscrim]

Reviewer: Travis Scrimshaw

[mkoeppe]

comment:8

Thanks!

[vbraun]

Changed branch from u/mkoeppe/sage_tensor_modules_free_module_basis__add_testsuite to f1f67d3