get doctest coverage of databases/stein_watkins.py to 100%

[mminzlaff]

Part of metaticket #12024.

See also this sage-nt thread

Apply attachment: trac_12092_doctests-v3.patch and attachment: trac_12092-reviewer.patch.

Upstream: Reported upstream. Developers acknowledge bug.

CC: @williamstein

Component: doctest coverage

Author: Moritz Minzlaff

Reviewer: Karl-Dieter Crisman, David Loeffler, Frédéric Chapoton, Jeroen Demeyer

Merged: sage-5.7.beta4

Issue created by migration from https://trac.sagemath.org/ticket/12092

[mminzlaff]

comment:1

One thing I found curious was the function _lines(s). It doesn't seem to be used anywhere and moreover when iterating over the input string, it skips over the last line. (Was this somehow related to #10582 ?)

[kcrisman]

comment:2

In general, this looks good. However, I have a suspicion that it may not actually work. Note that all the original doctests at the top have

# optional - stein_watkins_database

Should that be added to the others? Likely.

I agree about _lines. It's not used anywhere.

sage: search_src('\._lines')
databases/stein_watkins.py:202:        sage: l = sage.databases.stein_watkins._lines("\n some \ntext")
geometry/cone.py:392:        cone._lines = lines
geometry/cone.py:2765:            self._lines = lines
geometry/cone.py:2766:        return self._lines
geometry/polyhedra.py:3054:            return self._lines
geometry/polyhedra.py:3056:            self._lines = [list(x) for x in self.line_generator()]
geometry/polyhedra.py:3057:            return self._lines   
interfaces/qepcad.py:2183:        self._lines = lines

This has been in Sage practically from the beginning, though. cc:ing William, but I suppose we can leave it in for now.

changeset:   0:039f6310c6fe
user:        tornaria@math.utexas.edu
date:        Sat Feb 11 01:13:08 2006 +0000
summary:     [project @ original sage-0.10.12]

[kcrisman]

Reviewer: Karl-Dieter Crisman

[mminzlaff]

comment:3

Many thanks for your comments! "# optional ..." now added everywhere.

[mminzlaff]

Description changed:

--- 
+++ 
@@ -1 +1,3 @@
-Part of metaticket #12024
+Part of metaticket #12024.
+
+Apply [trac_12092_doctests-v2.patch](https://github.com/sagemath/sage/files/ticket12092/trac_12092_doctests-v2.patch.gz)