Do not generate pipestatus from spkg/install

[vbraun]

The $SAGE_ROOT/spkg/install has a here document that creates pipestatus. With the sage root repository, this is no longer needed as pipestatus is tracked by the repository. The patch removes it from $SAGE_ROOT/spkg/install.

---

Patch moved to #11073.

CC: @jdemeyer @nexttime

Component: build

Keywords: sd32

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/10970

[vbraun]

Attachment: trac_10970_do_not_generate_pipestatus.patch.gz

Patch to SAGE_ROOT repo

[sagetrac-mariah]

comment:2

Patch applied, then patched file moved to new source directory. 'make testlong' passed all tests. Positive review.

[sagetrac-mariah]

Reviewer: Mariah Lenox

[vbraun]

comment:3

I've recently played around with automatic testing upgrades and I think this might break upgrades. Its really a bigger issue, the sage_root repository is only upgraded rather late in the upgrade process. I think this needs to be fixed first. I will do some more testing when I have time.

I'll set this ticket to "needs info" until I (or somebody else) tests upgrading.

[jhpalmieri]

comment:4

My guess is that if this causes problems with upgrading, it should only happen when upgrading from versions of Sage which don't already include the file "pipestatus", which would mean some version between 4.4.4 (which doesn't have it) and 4.5.3 (which does). I haven't actually tested anything, though.

Maybe the root repository should be upgraded earlier. In an install from scratch, it has to be installed somewhat late because it depends on mercurial, but when upgrading, mercurial should already be present. This would require altering the upgrade process so that it doesn't just run spkg/install. We could install the root repo by hand (in sage-upgrade) before running spkg/install.