Skip to content

Add Python 3.14 support#190

Merged
dimpase merged 7 commits intosagemath:masterfrom
tobiasdiez:patch-1
Oct 31, 2025
Merged

Add Python 3.14 support#190
dimpase merged 7 commits intosagemath:masterfrom
tobiasdiez:patch-1

Conversation

@tobiasdiez
Copy link
Contributor

@tobiasdiez tobiasdiez commented Oct 21, 2025

Fixes #191

@tobiasdiez

This comment was marked as outdated.

@tobiasdiez tobiasdiez marked this pull request as draft October 21, 2025 13:55
@tobiasdiez tobiasdiez changed the title Add Python 3.14 to GitHub CI Add Python 3.14 support Oct 30, 2025
@tobiasdiez tobiasdiez marked this pull request as ready for review October 30, 2025 07:08
@dimpase
Copy link
Member

dimpase commented Oct 30, 2025

oops, I overlooked this one, see #191

I thought that we already have 3.14(non-t) support, so I started adding 3.14(non-t) to the CI...

@dimpase
Copy link
Member

dimpase commented Oct 30, 2025

As I see, I already pushed 2.2.3 tag :-(

@dimpase
Copy link
Member

dimpase commented Oct 30, 2025

it does build, but does it actually work?

@dimpase
Copy link
Member

dimpase commented Oct 30, 2025

@tobiasdiez
Copy link
Contributor Author

@dimpase should work now with this PR

@dimpase dimpase merged commit 9fd1a09 into sagemath:master Oct 31, 2025
18 checks passed
@tobiasdiez tobiasdiez deleted the patch-1 branch October 31, 2025 03:14
@dimpase
Copy link
Member

dimpase commented Oct 31, 2025

there seems to be a CI bug: tests only run on a tag push, not on a PR merge

@dimpase
Copy link
Member

dimpase commented Oct 31, 2025

more precisely, build+test is run on a PR being submitted, but it's not run on pushes which don't push a tag.

@tobiasdiez
Copy link
Contributor Author

yes, I'll open another PR that fixes this.
As preparation for this, could you please rename the master branch to main?

@dimpase
Copy link
Member

dimpase commented Oct 31, 2025

yes, I'll open another PR that fixes this. As preparation for this, could you please rename the master branch to main?

done, see #192

@dimpase
Copy link
Member

dimpase commented Oct 31, 2025

@tobiasdiez - can we release now, or you want more PRs merged?

@tobiasdiez
Copy link
Contributor Author

You can release now in my opinion, fixing the CI doesn't require a new release anyway and I don't think anything else is planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

port to freethreading python?

2 participants