-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exploring our merging policy #42
Comments
Hey guys, I forked to add some brazilian memes, but I didn't do it because Brunno dos Santos* brunno.me | github https://github.com/squiter85 | Stack On Thu, Sep 19, 2013 at 9:52 PM, Chris [email protected] wrote:
|
I forked because I wanted to add random icons that weren't present that my friends and I use. Once I add new icons, I typically build for Adium and Pidgin and send it out to the people I talk to. It's not a fantastic release strategy, but it works ok since I only send it out to 5-10 people. I attempted a pull request once, but it was denied for not being an actual "trollicon", which is understandable. I also have a few things that I probably wouldn't push back just because they're not super high quality or are really niche things that we use. What I should probably have done is create a new repository with just the icons that we use and then activate multiple icon packs in our chat clients. |
My fork was made for the same reason as @apazzolini |
Same here as @apazzolini and @patbenatar. I think this repo is a great starting point for the most relevant memes, and each can expand with their own interests… And with that said, me and my friends have moved over to a Google Hangouts group chat and haven't used troll icons for a while now. |
Thanks for the feedback guys. I've merged in some of the pull requests I've previously closed. The next project I'm working on is customizable download packs, akin to something like this http://getbootstrap.com/customize/ As such we will be decidedly more liberal with our merging from now on :) |
Sorry for the late reply, but I also added two icons and distributed them On Fri, Sep 20, 2013 at 1:55 PM, Chris [email protected] wrote:
|
Late reply, sorry everyone. I forked trollicons to add a bunch of memes that weren't around, and a couple of faces to keep up with inside jokes. Also added a post-image processing to enable rotating and mirroring of rage faces when building the final bundle. |
We haven't been merging much from the community. As such, trollicons is very fragmented.
We'd like to get get input from you guys to see why you've forked trollicons, what you've done in your forks, and how you deploy your packages.
@sagargp
@wetsixteen
@patbenatar
@carlosefonseca
@squiter85
@Shadow6363
@avik-das
@apazzolini
@rfsbraz
@jfridye
Thanks!
The text was updated successfully, but these errors were encountered: