Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all sizes of icons for different desktops are created #93

Closed
mattkeenan opened this issue Jul 23, 2023 · 4 comments · May be fixed by #95
Closed

Not all sizes of icons for different desktops are created #93

mattkeenan opened this issue Jul 23, 2023 · 4 comments · May be fixed by #95
Labels
bug TYPE: a report on something that isn't working stale ATTRIBUTE: this issue has not had recent activity

Comments

@mattkeenan
Copy link
Contributor

mattkeenan commented Jul 23, 2023 •
edited
Loading

What happened:

When I installed the package the portmaster icon didn't appear in the workspace switcher (XFCE)

What did you expect to happen?:

The window preview icon to appear like other apps.

How did you reproduce it?:

Installed the package on 22.04 XUbuntu

Suggested Fix:

Provide app icons at the same sizes that Firefox uses. This would also include an SVG version of the icon; I got a copy from the safing website.

I'll post a PR shortly, and then edit this issue as I can't comment on issues without closing as I don't have permissions to add non closing comments.

Debug Information:

Icon files for only the following sizes exist in /usr/share/icons/hicolor

128x128/apps/portmaster.png
16x16/apps/portmaster.png
32x32/apps/portmaster.png
48x48/apps/portmaster.png
96x96/apps/portmaster.png

Compared to, for example, firefox

128x128/apps/firefox.png
16x16/apps/firefox.png
22x22/apps/firefox.png
24x24/apps/firefox.png
256x256/apps/firefox.png
32x32/apps/firefox.png
48x48/apps/firefox.png
64x64/apps/firefox.png
symbolic/apps/firefox-symbolic.svg
@mattkeenan mattkeenan added the bug TYPE: a report on something that isn't working label Jul 23, 2023
mattkeenan added a commit to mattkeenan/portmaster-packaging that referenced this issue Jul 23, 2023
@mattkeenan
Add normally available app logo icons to linux pkgs
f06968a 
  - fix for issue safing#93
  - adds normally missing icon sizes
  - adds SVG icon
mattkeenan added a commit to mattkeenan/portmaster-packaging that referenced this issue Jul 23, 2023
@mattkeenan
Add normally available app logo icons to linux pkgs
a8d9f9d 
  - fix for issue safing#93
  - adds normally availble icon sizes that are missing
  - adds SVG icon
@mattkeenan mattkeenan mentioned this issue Jul 23, 2023
Closed
mattkeenan added a commit to mattkeenan/portmaster-packaging that referenced this issue Jul 23, 2023
@mattkeenan
Add normally available app logo icons to linux pkgs
ec73f99 
  - fix for issue safing#93
  - adds normally availble icon sizes that are missing
  - adds SVG icon
This was referenced Jul 23, 2023
Open
Closed
@github-actions
Copy link

This issue has been automatically marked as inactive because it has not had activity in the past two months.

If no further activity occurs, this issue will be automatically closed in one week in order to increase our focus on active topics.

@github-actions github-actions bot added the stale ATTRIBUTE: this issue has not had recent activity label Sep 25, 2023
@dhaavi
Copy link
Member

dhaavi commented Sep 25, 2023

Will be fixed by #95.

@dhaavi dhaavi linked a pull request Sep 25, 2023 that will close this issue
Add normally available app logo icons to linux pkgs #95
Open
@github-actions github-actions bot removed the stale ATTRIBUTE: this issue has not had recent activity label Sep 26, 2023
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as inactive because it has not had activity in the past two months.

If no further activity occurs, this issue will be automatically closed in one week in order to increase our focus on active topics.

@github-actions github-actions bot added the stale ATTRIBUTE: this issue has not had recent activity label Nov 28, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

This issue has been automatically closed because it has not had recent activity. Thank you for your contributions.

If the issue has not been resolved, you can find more information in our Wiki or continue the conversation on our Discord.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug TYPE: a report on something that isn't working stale ATTRIBUTE: this issue has not had recent activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add normally available app logo icons to linux pkgs mattkeenan/portmaster-packaging
2 participants
@mattkeenan @dhaavi