-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to provide "Reason" for password retrieval #16
Conversation
- Note: not tested with AIM functions.
- Create the associated safes : sample-it-dept,sample-iaadmins,sample-coolteam | ||
- Create safe "BSA-SYS-PTT-R", and grant user "admin_bot" (see below) to the "Safe Management" permissions (for safe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will rename this safe with a more significant name eg: "RENAME_ME"
Thanks a lot for your contribution. Let me know why you logoff on tests rather than closing the session ? |
@safepost Sorry missed the earlier message. I was closing the session, more closely minic what a regular script would do.
I also ran into an issue with the logon account index. The code uses 2, and the default is 1 (I think).
Another thing that confused me a bit is the xml file keywards, upper case vs lower case vs camel case. What do you think of making it case insensitive?
Thanks |
Hi @ywei2017
|
It's great to see a fully featured python library. I was doing a PoC by running the tests, and found the missing of "Reason" in password retrievals, so I put in the PR.
The testing has some of the settings, and I updated the doc to help future testing.
** Note, I don't have the AIM module, so nothing changed for the AIM APIs.
Please let me know anything missing on the PR.