Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SafeMigration tests for zkSync #833

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Update SafeMigration tests for zkSync #833

merged 2 commits into from
Sep 19, 2024

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Sep 18, 2024 •
edited
Loading

This PR:

  • Partially solves Add zkSync Support To v1.4.1 #767 (test updates for SafeToL2Upgrade are still pending)
  • It is based on version 1.5.0 because 1.4.1 cannot be compiled at the moment because we used .send in there, and hardhat zksync compiler plugin needs to be updated to support suppressing errors. I will cherry-pick it later.
  • I updated the deployContract function name and return type to be more self-explanatory
  • The main changes were around adding zksync compatible bytecode and also using the ContractFactory from the "zksync-ethers" package because in ZkSync you need to interact with a system contract to deploy contracts and not just send a transaction with the bytecode and to address omitted.

One bug found: matter-labs/hardhat-zksync#1420

@mmv08 mmv08 requested review from a team, nlordell, akshay-ap and remedcu and removed request for a team September 18, 2024 12:18
@coveralls
Copy link

coveralls commented Sep 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10945658354

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.571%
Totals Coverage Status
Change from base Build 10920545864: 0.0%
Covered Lines: 396
Relevant Lines: 408
💛 - Coveralls

akshay-ap
akshay-ap approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@akshay-ap akshay-ap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmv08 mmv08 merged commit 70673bb into main Sep 19, 2024
23 checks passed
@mmv08 mmv08 deleted the migration-tests-zksync branch September 19, 2024 17:19
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@remedcu remedcu remedcu approved these changes

@akshay-ap akshay-ap akshay-ap approved these changes

@nlordell nlordell Awaiting requested review from nlordell nlordell was automatically assigned from safe-global/safe-protocol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmv08 @coveralls @akshay-ap @remedcu