-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.3.0 libs.0 zksync #588
base: v1_3_0_zksync
Are you sure you want to change the base?
1.3.0 libs.0 zksync #588
Conversation
package.json
Outdated
@@ -44,31 +47,36 @@ | |||
"url": "https://github.com/gnosis/gnosis-safe/issues" | |||
}, | |||
"devDependencies": { | |||
"@elvis-krop/hardhat-deploy": "0.11.29-ethers5.5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference of this to the normal hardhat-deploy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @rmeissner 👋
We are waiting for an action under this PR in hardhat-deploy. You can read more details in the description.
During the development, we realised that v0.11.25 and previous versions doesn't work properly for zkEVM deployments and testing. Moreover, v0.11.26 and further releases include incompatible versions of @ethersproject/* with safe-contracts repo ethers.js and some tools for testing.
We expected to have an intermediate release of hardhat-deploy for this, however owner doesn't reply us
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt that they will be downgrading their ethers dependency. You can force a specific resolution of a dependency with yarn afaik (see https://classic.yarnpkg.com/en/docs/selective-version-resolutions/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rmeissner!
✔️ done at b492bce
…ethersproject/contracts`
Adjustments to use existing deterministic deployment scripts
Just to note: we will not merge this PR as this is just a temporary solution to deploy 1.3.0. |
This PR adds support to test and deploy safe-contracts 1.3.0 to zkSync network.
The process is described in zkSync Network section in Readme.md