Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport the migration contract to v1.4.1 #781

Closed
nlordell opened this issue Jul 3, 2024 · 1 comment
Closed

Backport the migration contract to v1.4.1 #781

nlordell opened this issue Jul 3, 2024 · 1 comment
Assignees
@mmv08

Comments

@nlordell
Copy link
Collaborator

nlordell commented Jul 3, 2024 •
edited by mmv08
Loading

Context / issue

We are in the process of auditing additional Safe library contracts that need to be used by the Wallet team. At the current time, the library contracts planned for audit are:

  • The Safe v1.3.0 to v1.4.1 migration contract
  • The Safe L1 to L2 migration contract
  • The Safe cross-chain setup contract

These changes should be made to the v1.4.1 branch, as we will be deploying these as additional v1.4.1 library contracts.

Proposed solution

Ensure that all of the planned audited contracts are part of the deployment scripts.

Alternatives

Require manual deployments for these contracts

Expected Outcome

A dev/v1.4.1 branch with backports including:

  • Library contracts that are to be deployed
  • Deployment scripts introduced in 1.
@mmv08 mmv08 mentioned this issue Jul 17, 2024
Merged
@mmv08 mmv08 changed the title Add Library Contracts to Deployment Scripts Backport the migration contract to v1.4.1 Jul 22, 2024
@mmv08 mmv08 mentioned this issue Jul 22, 2024
Merged
mmv08 added a commit that referenced this issue Jul 23, 2024
@mmv08 @akshay-ap
@nlordell @remedcu @Uxio0
1.4.1 Feature: Backport migration contracts to 1.4.1 (#795)
ab1e24e 
This PR implements
#781.

It migrates the migration contracts from:
- #685
- #793

I had to refactor tests quite a bit because a lot has changed since the
release of 1.4.1 like we added typechain types, migrated to ethers v6,
etc

---------

Co-authored-by: Akshay <[email protected]>
Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
Co-authored-by: Shebin John <[email protected]>
Co-authored-by: Uxío <[email protected]>
@mmv08 mmv08 mentioned this issue Jul 23, 2024
Merged
mmv08 added a commit that referenced this issue Jul 24, 2024
@mmv08 @nlordell
1.4.1: Backport SafeToL2Setup contract (#800)
e69f6f0 
A follow up to
#795 completely
fixing #781.

This PR migrates:
- #759

And adjusts the tests for ethers v5

---------

Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
@nlordell
Copy link
Collaborator Author

This is in the 1.4.1-2 branch.

dodger213 added a commit to dodger213/safe-smart-contract that referenced this issue Aug 18, 2024
@dodger213 @akshay-ap
@nlordell @remedcu @Uxio0
1.4.1 Feature: Backport migration contracts to 1.4.1 (#795)
79cdf15 
This PR implements
safe-global/safe-smart-account#781.

It migrates the migration contracts from:
- safe-global/safe-smart-account#685
- safe-global/safe-smart-account#793

I had to refactor tests quite a bit because a lot has changed since the
release of 1.4.1 like we added typechain types, migrated to ethers v6,
etc

---------

Co-authored-by: Akshay <[email protected]>
Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
Co-authored-by: Shebin John <[email protected]>
Co-authored-by: Uxío <[email protected]>
nlordell added a commit that referenced this issue Sep 10, 2024
@mmv08 @akshay-ap
@nlordell @remedcu @Uxio0
1.4.1 Feature: Backport migration contracts to 1.4.1 (#795)
db694b9 
This PR implements
#781.

It migrates the migration contracts from:
- #685
- #793

I had to refactor tests quite a bit because a lot has changed since the
release of 1.4.1 like we added typechain types, migrated to ethers v6,
etc

---------

Co-authored-by: Akshay <[email protected]>
Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
Co-authored-by: Shebin John <[email protected]>
Co-authored-by: Uxío <[email protected]>
nlordell added a commit that referenced this issue Sep 10, 2024
@mmv08 @nlordell
1.4.1: Backport SafeToL2Setup contract (#800)
0182e25 
A follow up to
#795 completely
fixing #781.

This PR migrates:
- #759

And adjusts the tests for ethers v5

---------

Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmv08 mmv08

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nlordell @mmv08