Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiSendCallOnly can be further optimized to save gas #372

Open
skeletor-spaceman opened this issue Dec 23, 2021 · 1 comment
Open

MultiSendCallOnly can be further optimized to save gas #372

skeletor-spaceman opened this issue Dec 23, 2021 · 1 comment
Labels
future Features for next major contract version

Comments

@skeletor-spaceman
Copy link

Context / issue

there is no need to pack the value if we are sending all value-less packed txs

Proposed solution

add a way to know which optimizations are being used in the transactions bytes. and unpacked correctly at SC level.

Additional context

this can also be done with OperationType and to parameters
fdarian pushed a commit to fdarian/safe-contracts that referenced this issue Jan 14, 2024
@yagopv
feat(onramp-kit): Monerium integration (safe-global#372)
fb98dc5 
* Allow to pass EthAdapter from outside

* Use EthAdapter as parameter

* Add auth-kit

* Extract refreshToken to outside

* Rename to packs and upgrade monerium sdk

* Add socket listener connection

* Add subscriptions to sockets

* Upgrade monerium sdk to support node 16

* Add test
@nlordell nlordell reopened this Oct 31, 2024
@nlordell nlordell added future Features for next major contract version and removed wontfix labels Oct 31, 2024
@nlordell
Copy link
Collaborator

There could be an additional method in the MultiSend contract optimised for only doing CALLs with no value (and use smaller data).

For now, we will not implement this, as it would be a new method and there isn't much demand for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
future Features for next major contract version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nlordell @skeletor-spaceman