Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set a transaction guard for each enabled module #335

Closed
auryn-macmillan opened this issue Aug 20, 2021 · 3 comments
Closed

Allow to set a transaction guard for each enabled module #335

auryn-macmillan opened this issue Aug 20, 2021 · 3 comments

Comments

@auryn-macmillan
Copy link
Contributor

Context / issue

Transaction guards are a really powerful feature for the Gnosis Safe, but they are currently limited only to multisig transactions. Any installed modules circumvent an enabled transaction guard. If a user would like to implement similar logic for a module, they would need to implement it either as part of their module or as a modifier module that sits between their module and the safe.

Proposed solution

Allow users to optionally enable a guard for each enabled module. This would allow each enabled module to have distinct pre and/or post-checks that it must pass each time it time it attempts to execute a proposal.

Alternatives

The alternative is to build this logic directly into modules or as a modifier module that sits between enabled modules and the safe. In either case, this would mean duplicating code to enable similar guard functionality for module and multisig transactions.

Additional context

If this is implemented, we can create a IGuardable.sol interface in Zodiac and encourage the DAO community to build more compatible transaction guards.

@Emmanuelruina
Copy link

Deployment approve

@mmv08
Copy link
Member

mmv08 commented Nov 15, 2023

Deployment approve

Thanks

fdarian pushed a commit to fdarian/safe-contracts that referenced this issue Jan 14, 2024
…d_yarn/http-cache-semantics-4.1.1

Bump http-cache-semantics from 4.1.0 to 4.1.1
@remedcu
Copy link
Member

remedcu commented Oct 31, 2024

Module Guard was introduced in #571

@remedcu remedcu closed this as completed Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@auryn-macmillan @mmv08 @remedcu @Emmanuelruina and others