fix: formatter now rounds numbers down and displays only 1 decimal #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Branch preview✅ Deployed to dev: |
|
You might be able to leverage the |
|
I found that I've also checked the available libs in https://github.com/microsoft/TypeScript/tree/main/src/lib and the updates of Intl do not include NumberFormat so this option is unusable at the moment. |
DiogoSoaress
commented
Sep 5, 2023
| @@ -33,7 +33,7 @@ export const fetchTotalSafesDeployed = async (): Promise<number | null> => { | |||
| } | |||
|
|
|||
| export const useSafeStats = (): Array<string | null> => { | |||
| const { totalAssets, totalSafesDeployed, totalTransactions } = useContext(SafeStatsContext) | |||
| const { totalTransactions, totalAssets, totalSafesDeployed } = useContext(SafeStatsContext) | |||
There was a problem hiding this comment.
Changed the variables order to keep consistency with the following code.
katspaugh
approved these changes
Sep 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
The displayed Safe stats should never be rounded up.
How this PR fixes it
en-USlocale for number formatting