Updated grover config #1932
Open
Updated grover config #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keshavbiswa
reviewed
Nov 14, 2024
There was a problem hiding this comment.
LGTM! Haven't tested it yet. Can @apoorv1316 test this on staging and confirm it's working as expected?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added swap to worker machine this will fix the memory issue.
Grover config changes:
prefer_css_page_sizeset tofalseas we don't have any page css property.timeoutto 30 seconds. This will avoid Grover to waiting indefinitively which will also increase the memory usage and cause the server to restart.--disable-gpuas launch_args to disable the GPU acceleration.javascript_enabled: falseas the PDF pages are static.Removed
networkidle0andnetworkidle2asloadshould be enough to get the images from s3 and it will reduce the 500 millisecond wait.Fixed the address issue in organization edit form.