-
Notifications
You must be signed in to change notification settings - Fork 2
PRB Feedback for TypeScript #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
95f40e3
Comprehensive refactoring and improvements
PaulRBerg bdd1a90
ci: cache build artifacts
PaulRBerg 90e05f5
test: context class instead of loose base
PaulRBerg d076eb2
chore: include reporters in vitest config
andreivladbrg 9867adc
feat: codegen-structs
PaulRBerg 4d1344f
feat: integrate and use codegen-structs
PaulRBerg 1443dd1
chore: add build log
PaulRBerg 378a06c
chore: allow unexpected_cfgs
andreivladbrg 6d87886
chore: nitpicks
andreivladbrg 2492604
refactor: naming & cleaning
IaroslavMazur b763c35
fix: address PR feedback
PaulRBerg b537e15
perf: look only for BN and PublicKey
PaulRBerg 030805c
docs: update license in "package.json"
PaulRBerg 242c3eb
tests: namespaces in defaults.ts
IaroslavMazur 750af46
scripts: refactor extractIdlField()
IaroslavMazur 79e0e4e
style: format
andreivladbrg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "permissions": { | ||
| "allow": [ | ||
| "Bash(find:*)", | ||
| "Bash(git:*)", | ||
| "Bash(just:*)", | ||
| "Bash(ls:*)", | ||
| "Bash(mkdir:*)", | ||
| "Bash(ni:*)", | ||
| "mcp__http-server__*", | ||
| "WebFetch(domain:anthropic.com)", | ||
| "WebFetch(domain:github.com)", | ||
| "WebFetch(domain:npmjs.com)", | ||
| "WebFetch(domain:raw.githubusercontent.com)", | ||
| "WebFetch(domain:sablier.com)" | ||
| ], | ||
| "deny": ["Bash(git checkout:*)", "Bash(git reset:*)", "Bash(git unstage:*)", "Bash(rm -rf:*)"] | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| name: "CI" | ||
|
|
||
| concurrency: | ||
| cancel-in-progress: true | ||
| group: ${{github.workflow}}-${{github.ref}} | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: ["main"] | ||
|
|
||
| jobs: | ||
| ci: | ||
| runs-on: "macos-latest" | ||
| steps: | ||
| - name: "Check out the repo" | ||
| uses: "actions/checkout@v4" | ||
|
|
||
| - name: "Set up Sablier devkit and install Node.js dependencies" | ||
| uses: "sablier-labs/devkit/actions/setup@main" | ||
| with: | ||
| package-manager: "bun" | ||
|
|
||
| - name: "Set up Rust, Solana, and Anchor" | ||
| uses: "sablier-labs/gha-utils/.github/actions/anchor-toolchain@main" | ||
| with: | ||
| anchor-version: "0.31.1" | ||
| rust-version: "nightly" | ||
| solana-version: "2.1.21" | ||
|
|
||
| - name: "Cache Anchor build artifacts" | ||
| id: "cache-build" | ||
| uses: "sablier-labs/gha-utils/.github/actions/solana-cache@main" | ||
| with: | ||
| cache-path: target | ||
|
|
||
| - name: "Build the programs" | ||
| if: steps.cache-build.outputs.cache-status != 'primary' | ||
| run: "just build" | ||
|
|
||
| - name: "Run the Rust code checks" | ||
| if: steps.cache-build.outputs.cache-status != 'primary' | ||
| run: "just rust-check" | ||
|
|
||
| - name: "Run the other code checks" | ||
| run: | # shell | ||
| just prettier-check | ||
| just biome-check | ||
| just tsc-check | ||
|
|
||
| - name: "Run the tests" | ||
| if: steps.cache-build.outputs.cache-status != 'primary' | ||
| run: "just test-lite" | ||
|
|
||
| - name: "Add summary" | ||
| run: | # shell | ||
| echo "## CI result" >> $GITHUB_STEP_SUMMARY | ||
| echo "✅ Passed" >> $GITHUB_STEP_SUMMARY |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| lint-staged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| /** | ||
| * @type {import("lint-staged").Configuration} | ||
| */ | ||
| module.exports = { | ||
| "*.{js,json,jsonc,ts}": "na biome check --no-errors-on-unmatched --write", | ||
| "*.{js,ts}": "na biome lint --no-errors-on-unmatched --unsafe --write --only correctness/noUnusedImports", | ||
| "*.{md,yml}": "na prettier --cache --write", | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,9 @@ | ||
| # directories | ||
| .anchor | ||
| build | ||
| dist | ||
| node_modules | ||
| repomix | ||
| target | ||
| test-ledger | ||
|
|
||
| # files | ||
| *.env | ||
| *.log | ||
| *.tsbuildinfo | ||
| .DS_Store | ||
| .pnp.* | ||
| bun.lock | ||
| bun.lockb | ||
| npm-debug.log | ||
| package-lock.json | ||
| pnpm-lock.yaml | ||
| yarn.lock | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| const baseConfig = require("@sablier/devkit/prettier"); | ||
|
|
||
| /** | ||
| * @see https://prettier.io/docs/configuration | ||
| * @type {import("prettier").Config} | ||
| */ | ||
| const config = baseConfig; | ||
|
|
||
| module.exports = config; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "recommendations": [ | ||
| "amasfe.even-better-toml", | ||
| "biomejs.biome", | ||
| "esbenp.prettier-vscode", | ||
| "nefrob.vscode-just-syntax", | ||
| "stackbreak.comment-divider", | ||
| "rust-lang.rust-analyzer" | ||
| ] | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.