Conversation
|
Foundry has recently implemented my feature request (ref foundry-rs/foundry#4085) for selective test fuzz runs. See this PR: It is now possible to override the number of default fuzz runs in a particular test, like this: /// forge-config: default.fuzz.runs = 100
/// forge-config: ci.fuzz.runs = 500
function test_SimpleFuzzTest(uint256 x) public {
// --- snip ---
}We should consider doing this for our tests which fuzz arrays. |
andreivladbrg
left a comment
andreivladbrg
left a comment
There was a problem hiding this comment.
We should consider doing this for our tests which fuzz arrays
How would you configure it?
| test-invariant: | ||
| env: | ||
| FOUNDRY_INVARIANT_DEPTH: ${{ inputs.invariantDepth || "100" }} | ||
| FOUNDRY_INVARIANT_RUNS: ${{ inputs.invariantRuns || "100" }} |
There was a problem hiding this comment.
We don't need the || "100" because we declared the inputs as required: false.
There was a problem hiding this comment.
We do need the || syntax for the cron-triggered workflow runs. Workflow inputs are not available in cron:
I don't know; I couldn't think of any particular test where this would be useful. This is the kind of feature that is best implemented on-the-go, not retrospectively. So I think we can leave it as is. |
ci: tone down the main CI workflow Closes #437
test: remove unneeded solady import in test utils
2 participants
Addresses #437.
Note that I did not test the CI workflow just yet.