Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added select/deselect all notes button #1377

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Edgiest05
Copy link

Introduced button in recent page footer that allows for selection of all notes

When less than all files are selected
immagine

When all files have already been selected, behaviour changes to unselect all
immagine

While implementing this I had to address that newer version of the saver_gallery dependency would not compile.
Furthermore preview_card makes use of a different variable expanded when it actually should never differ from the widget.selected one (or else some selection changes do not reflect in the UI). I've kept it for consistency's sake.

@Edgiest05 Edgiest05 changed the title Added select/deselect all button in recent page feat: Added select/deselect all button in recent page Oct 25, 2024
@Edgiest05 Edgiest05 changed the title feat: Added select/deselect all button in recent page feat: Added select/deselect all notes button Oct 26, 2024
@Edgiest05
Copy link
Author

Same functionality is now available also in each directory of the browse page

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 2.77778% with 35 lines in your changes missing coverage. Please review.

Project coverage is 47.63%. Comparing base (c1c3059) to head (620a0dc).

Files with missing lines Patch % Lines
lib/pages/home/browse.dart 0.00% 14 Missing ⚠️
lib/components/home/select_all_button.dart 0.00% 12 Missing ⚠️
lib/pages/home/recent_notes.dart 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1377      +/-   ##
==========================================
- Coverage   47.80%   47.63%   -0.17%     
==========================================
  Files         115      116       +1     
  Lines        9094     9127      +33     
==========================================
+ Hits         4347     4348       +1     
- Misses       4747     4779      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Edgiest05
Copy link
Author

Resolved merge conflicts and updated saver_gallery to new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant