-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add better support for stylus hovering #1355
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1355 +/- ##
==========================================
- Coverage 47.39% 47.34% -0.05%
==========================================
Files 114 114
Lines 8959 8976 +17
==========================================
+ Hits 4246 4250 +4
- Misses 4713 4726 +13 ☔ View full report in Codecov by Sentry. |
This looks good from the code. What device/s have you tested with? iirc pressing the S-pen button while hovering made the stylus not work temporarily |
I tested this on a Galaxy S6 Lite with the S-pen. Unfortunately I don't have access to another device with a stylus, so I can't test this further. It should work on other devices, though. |
Tested on Samsung Galaxy Tab S7 FE with Samsung pen. Works great |
Thanks! |
On my Galaxy Tab S6 is tool changed to Eraser when pressed button, but entities are not erased. So it does not work. Does erasing work for you? I am using official relase 0.25.3. |
I just tested the latest release, 0.25.3 on Galaxy S6 Lite. It appears to be working. Seems this is a rather sneaky bug. Maybe open an issue for it? |
I have found, that Preference "Automatically switch off Eraser" (do not know precise English name) does not work on my Saber 0.25.3. Even if this preference is switched On or Off, previous tool is used immediately after use of Eraser. I do not know if it can be connected. |
This PR adds handlers for hovering stylus events, which are used to switch to the eraser tool when the stylus button is pressed while hovering.
This replaces the old functionality where pressing the stylus button mid-stroke removes the stroke, making it more in-line with other note applications and (in my opinion) more user friendly.
Closes #859