Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQDEV-3522 + SQDEV-3566] M3 core tax compliance and cash payouts #86

Merged
merged 6 commits into from
Apr 10, 2024
Merged

[SQDEV-3522 + SQDEV-3566] M3 core tax compliance and cash payouts #86

merged 6 commits into from
Apr 10, 2024

Conversation

slisaasquatch
Copy link
Contributor

@slisaasquatch slisaasquatch commented Mar 4, 2024 •
edited by ianhitchcock
Loading

Description of the change

Added fulfilledByCashPayout for reward units

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

Links

Checklists

Development

  • Prettier was run (if applicable)
  • The behaviour changes in the pull request are covered by specs
  • All tests related to the changed code pass in development

Paperwork

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has a Jira number
  • This pull request has a Process.st launch checklist

Code review

  • Changes have been reviewed by at least one other engineer
  • Security impacts of this change have been considered

johanventer
johanventer requested changes Apr 1, 2024
View reviewed changes
Copy link
Member

@johanventer johanventer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR needs a description and hygiene, but otherwise this change is fine.

@ianhitchcock ianhitchcock changed the title M3 tax [SQDEV-3522 + SQDEV-3566] M3 core tax compliance and cash payouts Apr 2, 2024
@slisaasquatch slisaasquatch merged commit da59377 into master Apr 10, 2024
4 of 8 checks passed
@slisaasquatch slisaasquatch deleted the m3-tax branch April 10, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanventer johanventer johanventer approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slisaasquatch @johanventer