Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promo codes #427

Open
wants to merge 72 commits into
base: master
Choose a base branch
from
Open

Promo codes #427

wants to merge 72 commits into from
+2,166 −87

Conversation

00salmon
Copy link
Contributor

@00salmon 00salmon commented Dec 2, 2024

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

Links

  • Jira issue number: (PUT IT HERE)
  • Process.st launch checklist: (PUT IT HERE)

Checklists

Development

  • Prettier was run (if applicable)
  • The behaviour changes in the pull request are covered by specs
  • All tests related to the changed code pass in development

Paperwork

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has a Jira number
  • This pull request has a Process.st launch checklist

Code review

  • Changes have been reviewed by at least one other engineer
  • Security impacts of this change have been considered

00salmon and others added 30 commits November 18, 2024 15:07
@00salmon
added sqm-referral-code component
1e2e4df
@00salmon
added simple referral codes paginated component
a60d561
@zachharrison
Add pagination component
5425747
@zachharrison
Update story
7c329fe
@00salmon
added ability to override link on share link / share buttons
dea8322
@00salmon
add groups
76e192f
@00salmon
added override for story
6e64f28
@00salmon
added initial specs for referral codes component
83d18b0
@00salmon
wrong share medium in spec
17ef857
@00salmon
adding props from specs
5b3c872
@00salmon
cleanup
78bc786
@00salmon
edit spec to match different name
8f8f8d5
@zachharrison
Style referral code and add stories
6ab948a
@zachharrison
More styling updates
e3df42c
@zachharrison
Add optional notification to copy text view
23569e8
@zachharrison
Add css part
d59092a
@zachharrison
Update story
6743a54
@00salmon
update a bunch of components to support context overrides for their data
404cc83
@00salmon
bundle referral code exclusive components together
e1b6126
@00salmon
pagination demo hook
45c8b57
@00salmon
Update sqm-pagination.tsx
48f09a2
@00salmon
wire up demo hook for pagination
32423b8
@00salmon
added base example of referral codes component
e26cdfa
@00salmon
Merge branch 'master' into promo-codes
cab4741
@00salmon
publish
d0976ed
@00salmon
update specs
e0b67ab
@00salmon
add placeholder mutation for setting codes as copied
c6042a4
@00salmon
wire up to backend, added props for loading + empty state
b81e337
@00salmon
add engagementMedium to share links, query each different medium
a72dbc6
@00salmon
fixed a few issues with loading / copied states, wired up some more data
d929f0e
zachharrison
zachharrison requested changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@zachharrison zachharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things to cleanup, but otherwise things look good to me

Locrian24
Locrian24 reviewed Feb 6, 2025
View reviewed changes
packages/mint-components/src/components/sqm-referral-codes/sqm-referral-codes.tsx

/**
* @uiName Referral Codes
* @slots [{"name":"", "title":"Promo Codes Content"}]
Copy link
Contributor

@Locrian24 Locrian24 Feb 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Slots seem incomplete, should have "empty" and "loading" at least no?

Copy link
Contributor Author

@00salmon 00salmon Feb 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case it looks like the loading and empty state are hard-coded in the file, might be a question of whether we should change that

Locrian24
Locrian24 reviewed Feb 6, 2025
View reviewed changes
packages/mint-components/package.json
@@ -1,7 +1,7 @@
{
"name": "@saasquatch/mint-components",
"title": "Mint Components",
"version": "1.11.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagging pre-release

@Locrian24
Copy link
Contributor

Remove sqm-pagination.feature

00salmon
00salmon commented Feb 6, 2025
View reviewed changes
packages/mint-components/src/components/sqm-referral-codes/sqm-referral-codes.tsx Outdated
Comment on lines 74 to 77
<sqm-empty
emptyStateHeader="Your new codes and links aren’t ready yet"
emptyStateText="Please contact our program support team to let them know you’re out of codes."
></sqm-empty>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this empty state is not translatable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Locrian24 Locrian24 Locrian24 left review comments

@DerekSiemens DerekSiemens DerekSiemens left review comments

@zachharrison zachharrison zachharrison requested changes

@Ultha258 Ultha258 Ultha258 left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@00salmon @Locrian24 @DerekSiemens @zachharrison @Ultha258