Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (interactive) background correction #197

Open
wants to merge 49 commits into
base: newsolver
Choose a base branch
from

Conversation

minnerbe
Copy link
Collaborator

@minnerbe minnerbe commented Nov 8, 2024

This PR adds tools for correcting global shading on large FIBSEM volumes (e.g., here). These tools are:

  • Quadratic and fourth order models that fit the values of a function [(x, y) -> v], where x, y are the pixel coordinates (scaled to [-1, 1] x [-1, 1]) and v is the intensity value.
  • A small ImageJ plugin that allows to choose ROIs and fit such models (using only pixel values in the ROIs) interactively.
  • A spark client that corrects the intensity of large datasets block-wise.

For supplying model parameters to the spark client, I used an ad hoc json representation, since the model is expected to vary in z. This representation is documented in BackgroundCorrectionClient. Feedback about the documentation and the representation itself is very welcome.

One particular problem with doing this at the level of a stack is that we would need an exported mask to not also correct regions where there is no tissue. Is it safe to assume that a mask will always be exported when background correction is done? In this case, I will add support for masks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants