Fix creation of volatile/non-volatile N5Source pair #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken before, such that only the volatile Source was being used. Consequently, BDV movie recording etc didn't work properly.
bogovicj
approved these changes
Dec 8, 2022
|
Thanks @tpietzsch ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Construction of volatile versions of sources was broken.
Only the volatile Source was being used, and consequently BDV movie recording etc didn't work properly.
There is still a TODO left in the code about fixing the
CacheHints(which determine how blocks are enqueued).However, to address that, I would wait for imglib/imglib2-cache#18. Then it should be easily fixed by replacing the current code with the commented bit. For now, the
CacheHintsare set up as before, which is ok, but not ideal.The unnecessary class
N5VolatileSourcehas been removed, as well as theN5Source.asVolatile()methods which createdN5VolatileSource. So, this PR technically breaks API, but I doubt that this was used anywhere...