Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give black tape max power to enable more composing #15

Merged
merged 3 commits into from
Aug 17, 2018
Merged

Give black tape max power to enable more composing #15

merged 3 commits into from
Aug 17, 2018

Conversation

ryanve
Copy link
Member

@ryanve ryanve commented Aug 17, 2018

Before if you did class="tape-pink tape-black" then tape-black would be inert and you'd have black on pink same as if you had just tape-pink. This change affords composing class="tape-pink tape-black" to make pink on black without adding any additional code. #winning =)

@ryanve
Copy link
Member Author

ryanve commented Aug 17, 2018

  • .tape-white black on white
  • .tape-yellow black on yellow
  • .tape-pink black on pink
  • .tape-blue black on blue
  • .tape-green black on green
  • .tape-black parent on black
  • .tape-black.tape-white white on black
  • .tape-black.tape-yellow yellow on black
  • .tape-black.tape-pink pink on black
  • .tape-black.tape-blue blue on black
  • .tape-black.tape-green green on black

@ryanve
Copy link
Member Author

ryanve commented Aug 17, 2018

screenreader experience

black

and white

and green

and blue

and pink

and yellow

@ryanve ryanve merged commit 347bb67 into master Aug 17, 2018
@ryanve ryanve deleted the order branch August 17, 2018 04:55
@ryanve ryanve mentioned this pull request Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant