Add harsher linting rules. #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added operatins to: - Count the number of ones. - Count the number of zeroes. - Count the number of leading ones. - Count the number of leading Zeroes.
* Adds DIV/UDIV instruction. * Adds generic shift/rotation.
|
I think all of this is good going forward, to keep in mind is that there might be a couple of functions in Will wait to merging this before #1 is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add harsher linting rules
This PR adds harsher linting rules and ensures that the crate still builds by resolving the errors encountered. To ensure that future code contributions adhere to the standards and that future code contains valid or at least not broken documentation.
Future linting additions and modifications
I think that it would be good to remove the
#![allow(rustdoc::missing_crate_level_docs)]linting rule and adding top-level documentation for the crate.
Moreover, I think that the crate also should include the lining rule
#![deny(missing_docs)]But as I do not have full insight into what every part of the crate does I left that one for the future.
Testing
This PR has been tested by running the normal test suite after modifications.
Merging
This PR depends on #1 and is also a precursor to future inclusions of V7M functionality.