Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endless Loading on invalid archive #8

Closed
Simon-Laux opened this issue Jan 9, 2025 · 4 comments
Closed

Endless Loading on invalid archive #8

Simon-Laux opened this issue Jan 9, 2025 · 4 comments
Assignees

Comments

@Simon-Laux
Copy link

Simon-Laux commented Jan 9, 2025

image

Where does this issue come from? Safari extracts all zip files that it downloads, when using Finder to recompress/pack into a zip file the structure is (probably) different leading those errors.

There are two issues here:

  • MARL does not show any error to the user
  • MARL could also try to find the files in nested folders in the zip as fallback. (because this might be quite common for users on macOS)
@s427
Copy link
Owner

s427 commented Jan 9, 2025

Thanks for letting me know. I agree that MARL could be more helpful when it comes to error handling. This is something I plan to improve in a future version of the app.

As for the issue related to Safari, it might be a bit difficult for me to address it as I don't have easy access to a Mac. Can you give me more information about how the structure of the ZIP file is changed? Is it always the same?

To be clear (as I may be misunderstanding what happens), you just took your archive (as downloaded from your Mastodon instance) and simply dragged it on the app window, is that correct?

@Simon-Laux
Copy link
Author

Simon-Laux commented Jan 9, 2025

original:
Bildschirmfoto 2025-01-09 um 19 11 53
repackaged with finder, after safari extracted it:
Bildschirmfoto 2025-01-09 um 19 12 32

so I guess the logic would be:

  1. try known location (at zip root)
  2. if not found list files and if it is single directory and try to find the files in that directory.

@s427
Copy link
Owner

s427 commented Jan 9, 2025

Thank you. So basically, the files are repackaged to be inside a single folder which has the same name as the archive itself? That's weird but OK, I'll think about it.

@s427 s427 self-assigned this Jan 9, 2025
s427 added a commit that referenced this issue Jan 23, 2025

Verified

This commit was signed with the committer’s verified signature.
scala-steward Scala Steward
@s427
Copy link
Owner

s427 commented Jan 23, 2025

Both points raised above should be fixed in the latest version (uploaded just a few minutes ago):

  • better handling of invalid files (MARL should not remain stuck on the "loading" screen any more, and helpful error messages should be displayed in the UI);
  • if outbox.json and actors.json are not found at the root of the ZIP file, MARL will look for them in the whole archive and attempt to use their parent folder as the root folder for the whole archive.

@s427 s427 closed this as completed Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants