Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --skip-destination-validation option for setnotification #1277

Merged
merged 2 commits into from
Oct 4, 2022
Merged

add --skip-destination-validation option for setnotification #1277

merged 2 commits into from
Oct 4, 2022

Conversation

jeffwang0516
Copy link
Contributor

According to AWS spec for PutBucketNotificationConfiguration API,

x-amz-skip-destination-validation

Skips validation of Amazon SQS, Amazon SNS, and AWS Lambda destinations. True or false value.

https://docs.aws.amazon.com/AmazonS3/latest/API/API_PutBucketNotificationConfiguration.html#AmazonS3-PutBucketNotificationConfiguration-request-header-SkipDestinationValidation

fviard
fviard reviewed Oct 4, 2022
View reviewed changes
s3cmd Outdated Show resolved Hide resolved
@jeffwang0516 jeffwang0516 requested a review from fviard October 4, 2022 01:42
@fviard fviard added this to the 2.4.0 milestone Oct 4, 2022
@fviard fviard merged commit c91fd3e into s3tools:master Oct 4, 2022
@fviard
Copy link
Contributor

fviard commented Oct 4, 2022

Merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fviard fviard Awaiting requested review from fviard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffwang0516 @fviard