-
-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
list-objects-*: implement allow unordered option #1270
list-objects-*: implement allow unordered option #1270
Conversation
@fviard, if there is anything I can help about it, feel free to contact me. |
Sorry for the delay of my reply. Also, it will not be limited to "ls" anymore, but I think that it is ok, as s3cmd sync logic never assumed that file list would be in order for remote or local side. |
6a98067
to
d5fc25c
Compare
@fviard, as you requested, I changed it to a config variable. |
@snosratiershad You could have kept the "command line switch" in addition with the help, that was good. What is happening is that the config comes from the config file, but command line switches allow to override the config files. |
@fviard, should command line switch literally overide config file, or just ignoring the value comes from |
I realized what you mean. also going to change "list-objects-allow-unordered" to "list-allow-onordered". |
@fviard Done. |
b0fd9ec
to
26b3495
Compare
Merged, thank you! |
Delimiter cannot be used with allow-unordered. The code must not set a limiter if allow-unordered is true: |
@visbits Thanks for pointing this out. I'll check it out and fix it. |
As discussed in this issue