Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing return #1034

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Add missing return #1034

merged 1 commit into from
Oct 17, 2022

Conversation

Jamstah
Copy link
Contributor

@Jamstah Jamstah commented Mar 21, 2019

Batch delete fails to return a response object so callers cannot detect failures

Batch delete fails to return a response object so callers cannot detect failures
@fviard
Copy link
Contributor

fviard commented Mar 15, 2020

Hi,
I know that it is a little bit a long time ago, but this would not have been enough to change the behavior of anything as the caller is not looking at the reply anyway.
Can you tell me a little bit more about the context or the issue itself that you were encountering?
Thanks

@fviard fviard added this to the 2.4.0 milestone Oct 17, 2022
@fviard fviard merged commit 74bd1e9 into s3tools:master Oct 17, 2022
@fviard
Copy link
Contributor

fviard commented Oct 17, 2022

Merged thank you.

I got no reply, but I guess that it was requested only to be able to be used when "S3" is used as a lib for another program.
The change is harmless and makes the code more consistent.

@Jamstah
Copy link
Contributor Author

Jamstah commented Oct 17, 2022

Gosh, I can't remember what I was doing with it at the time, but thanks for the merge :)

Like you say, I was probably using it as a library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants