Pass type parameter to SyntheticEvent #703
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue/change
Currently the type of
event
thatSourceInfo
has isSyntheticEvent
with no type argument. In the implementation, I believe that it is theinput
element that fires the event, soSyntheticEvent<HTMLInputElement>
should be more appropriate here. This change will improve integration with other libraries such as MUI in terms of TypeScript types.Add CodeSandbox link to illustrate the issue (If applicable)
Describe specs for failing cases if this is an issue (If applicable)
Describe the changes proposed/implemented in this PR
https://github.com/s-yadav/react-number-format/blob/master/src/types.ts#L23
befor:
SyntheticEvent
after:
SyntheticEvent<HTMLInputElement>
Link Github issue if this PR solved an existing issue
Example usage (If applicable)
Screenshot (If applicable)
Please check which browsers were used for testing