Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: peerDependencies in package.json #565

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Conversation

navarroaxel
Copy link
Contributor

Describe the issue/change

This package fails to install with npm@7 and npm --legacy-peer-deps should be used to ignore this error.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR! react@"17.0.1" from the root project
npm ERR! peer react@"^0.14 || ^15.0.0-0 || ^16.0.0-0 || ^17.0.0-0" from [email protected]
npm ERR! node_modules/react-number-format
npm ERR! dev react-number-format@"^4.6.4" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"17.0.2" from [email protected]
npm ERR! node_modules/react-dom
npm ERR! peer react-dom@"^0.14 || ^15.0.0-0 || ^16.0.0-0 || ^17.0.0-0" from [email protected]
npm ERR! node_modules/react-number-format
npm ERR! dev react-number-format@"^4.6.4" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Add CodeSandbox link to illustrate the issue (If applicable)

Describe specs for failing cases if this is an issue (If applicable)

Describe the changes proposed/implemented in this PR

Remove package release -0 into the peerDependencies versions.

Link Github issue if this PR solved an existing issue

Example usage (If applicable)

Screenshot (If applicable)

image

Please check which browsers were used for testing

  • Linux
  • Chrome (Android)
  • Safari (OSX)
  • Safari (iOS)
  • Firefox
  • Firefox (Android)

@changelogg
Copy link

changelogg bot commented Jul 18, 2021

Hey! Changelogs info seems to be missing or might be in incorrect format.
Please use the below template in PR description to ensure Changelogg can detect your changes:
- (tag) changelog_text
or
- tag: changelog_text
OR
You can add tag in PR header or while doing a commit too
(tag) PR header
or
tag: PR header
Valid tags: added / feat, changed, deprecated, fixed / fix, removed, security, build, ci, chore, docs, perf, refactor, revert, style, test
Thanks!
For more info, check out changelogg docs

@navarroaxel navarroaxel changed the title Fix peerDependencies en package.json fix: peerDependencies en package.json Jul 18, 2021
@navarroaxel navarroaxel changed the title fix: peerDependencies en package.json fix: peerDependencies ein package.json Jul 18, 2021
@navarroaxel navarroaxel changed the title fix: peerDependencies ein package.json fix: peerDependencies in package.json Jul 18, 2021
@s-yadav
Copy link
Owner

s-yadav commented Dec 1, 2021

Sorry for checking this late. Will merge.

@s-yadav s-yadav merged commit 8dc70fd into s-yadav:master Dec 1, 2021
@navarroaxel navarroaxel deleted the patch-1 branch December 1, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants