Sourcery Starbot ⭐ refactored s-rigaud/pyTelloSDK #2

SourceryAI · 2023-09-19T15:36:27Z

Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨

Here's your pull request refactoring your most popular Python repo.

If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch https://github.com/sourcery-ai-bot/pyTelloSDK master
git merge --ff-only FETCH_HEAD
git reset HEAD^

SourceryAI · 2023-09-19T15:36:29Z

abstract_drone.py

-except (ModuleNotFoundError, ImportError):
+except ImportError:


Lines 35-45 refactored with the following changes:

Remove redundant exceptions from an except clause [×2] (remove-redundant-exception)

Replace length-one exception tuple with exception [×2] (simplify-single-exception-tuple)

SourceryAI · 2023-09-19T15:36:29Z

abstract_drone.py

-            ip_net = ipaddress.ip_network(interface + '/24', strict=False)
+            ip_net = ipaddress.ip_network(f'{interface}/24', strict=False)


Function AbstractDrone.get_all_drones refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

SourceryAI · 2023-09-19T15:36:29Z

abstract_drone.py

-        if self.is_connected:
-            flight_mode = flight_mode.lower().strip()
-            if flight_mode == 'open pipe':
-                self.flight_mode = OpenPipeMode(self)
-
-            elif flight_mode == 'reactive':
-                self.flight_mode = ReactiveMode(self)
-
-            elif flight_mode == 'act from file':
-                if options.get('filename') is None:
-                    self.end_connection = True
-                    raise TypeError("You forgot filename argument. \nSee : https://github.com/s-rigaud/dev-pyTelloSDK#flightmodes for help")
-                else:
-                    self.flight_mode = ActFromFileMode(self, **options)
-
-            elif flight_mode == 'act from list':
-                if options.get('actions') is None:
-                    self.end_connection = True
-                    raise TypeError("You forgot actions argument. \nSee : https://github.com/s-rigaud/dev-pyTelloSDK#flightmodes for help")
-                self.flight_mode = ActFromActionListMode(self, **options)
-
-            elif flight_mode == 'picture mission':
-                if NO_VIDEO_DECODER:
-                    raise NoVideoDecoderError("Be sure you have access to either av library or libh264decoder")
-                self.flight_mode = PictureMission(self, **options)
+        if not self.is_connected:
+            return
+        flight_mode = flight_mode.lower().strip()
+        if flight_mode == 'act from file':
+            if options.get('filename') is None:
+                self.end_connection = True
+                raise TypeError("You forgot filename argument. \nSee : https://github.com/s-rigaud/dev-pyTelloSDK#flightmodes for help")
            else:
-                print('You enter an unrecognize flight mode')
+                self.flight_mode = ActFromFileMode(self, **options)
+
+        elif flight_mode == 'act from list':
+            if options.get('actions') is None:
                self.end_connection = True
+                raise TypeError("You forgot actions argument. \nSee : https://github.com/s-rigaud/dev-pyTelloSDK#flightmodes for help")
+            self.flight_mode = ActFromActionListMode(self, **options)
+
+        elif flight_mode == 'open pipe':
+            self.flight_mode = OpenPipeMode(self)
+
+        elif flight_mode == 'picture mission':
+            if NO_VIDEO_DECODER:
+                raise NoVideoDecoderError("Be sure you have access to either av library or libh264decoder")
+            self.flight_mode = PictureMission(self, **options)
+        elif flight_mode == 'reactive':
+            self.flight_mode = ReactiveMode(self)
+
+        else:
+            print('You enter an unrecognize flight mode')
+            self.end_connection = True


Function AbstractDrone.init_flight_mode refactored with the following changes:

Add guard clause (last-if-guard)

Simplify conditional into switch-like form [×2] (switch)

SourceryAI · 2023-09-19T15:36:29Z

abstract_drone.py

-            elif AV_AVAILABLE:
+            else:


Function AbstractDrone.process_frame refactored with the following changes:

Remove redundant conditional (remove-redundant-if)

SourceryAI · 2023-09-19T15:36:29Z

flight_modes.py

@@ -52,7 +52,6 @@ def start(self, **options):
                self.swarm.end_connection = True
                self.swarm.command_socket.close()
                break
-            # Useless escape chars


Function ReactiveMode.start refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

This removes the following comments ( why? ):

# Useless escape chars

SourceryAI · 2023-09-19T15:36:30Z

video_stream.py

-                data = data + self.queue[0]
+                data += self.queue[0]


Function VideoStream.read refactored with the following changes:

Replace assignment with augmented assignment (aug-assign)

SourceryAI · 2023-09-19T15:36:30Z

Tests/openpipe_udp.py

-        print("Sending message: " + message)
+        print(f"Sending message: {message}")
    except Exception as exc:
-        print("Error sending: " + str(exc))
+        print(f"Error sending: {str(exc)}")


Function send refactored with the following changes:

Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

SourceryAI · 2023-09-19T15:36:30Z

Tests/test_connection.py

-        print("Sending message: " + message)
+        print(f"Sending message: {message}")
    except Exception as exc:
-        print("Error sending: " + str(exc))
+        print(f"Error sending: {str(exc)}")


Function send refactored with the following changes:

Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

SourceryAI · 2023-09-19T15:36:31Z

Tests/test_state_receiver.py

-        print("Sending message: " + message)
+        print(f"Sending message: {message}")
    except Exception as exc:
-        print("Error sending: " + str(exc))
+        print(f"Error sending: {str(exc)}")


Function send refactored with the following changes:

Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

SourceryAI · 2023-09-19T15:36:31Z

Tests/test_video_stream.py

-    print("Sending message: " + message)
+    print(f"Sending message: {message}")
  except Exception as e:
-    print("Error sending: " + str(e))
+    print(f"Error sending: {str(e)}")
