Skip to content

270 ha addon add syntax check to config parameters #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 15, 2025

Conversation

mime24
Copy link
Collaborator

@mime24 mime24 commented Jan 15, 2025

to fix issue in RC

@s-allius s-allius merged commit 446a0d8 into dev-0.12 Jan 15, 2025
5 checks passed
@s-allius s-allius deleted the 270-ha-addon-add-syntax-check-to-config-parameters branch January 15, 2025 11:42
@s-allius
Copy link
Owner

@mime24 I rebuild the 0.12.1-rc, with your fix

@mime24
Copy link
Collaborator Author

mime24 commented Jan 15, 2025

perfect. seems working as expected.

fyi
I also tried what happens if we paste the config of the #269 issue.
the addon prevent from saving with following notification. unfortunately not super easy to read because it shows all parameters. but at the end it works as expected. :)

Fehler beim Speichern der Add-on Konfiguration, does not match regular expression ^(R17|Y17|Y47).{13}$. Got {'inverters': [{'serial': 'Y47E00000020000CE', 'monitor_sn': '2090000186', 'node_id': 'PV-Garage-links', 'suggested_area': 'Garage', 'modbus_polling': True, 'client_mode.host': '192.168.200.49', 'client_mode.port': 8899, 'client_mode.forward': False, 'pv1.manufacturer': 'Shinefar', 'pv1.type': 'SF-M18/144550', 'pv2.manufacturer': 'Shinefar', 'pv2.type': 'SF-M18/144550'}, {'serial': 'Y47E00000200000B', 'monitor_sn': '2090000183', 'node_id': 'PV-Garage-mitte', 'suggested_area': 'Garage', 'modbu...

@mime24
Copy link
Collaborator Author

mime24 commented Jan 15, 2025

just wait for a moment before you release. I just want to check something again

@mime24
Copy link
Collaborator Author

mime24 commented Jan 15, 2025

seems all fine

s-allius added a commit that referenced this pull request Jan 16, 2025
* bump version to 0.12.1

* add initial version for release candidates

* add rc version

* version 0.12.1

* addon: bump base image version to v17.1.0

* 270 ha addon add syntax check to config parameters (#274)

* fixed requirement status of client mode host

---------

Co-authored-by: Michael Metz <[email protected]>

---------

Co-authored-by: metzi <[email protected]>
Co-authored-by: Michael Metz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants