Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ELCA to leverage Ultranest verbosity controls #991

Merged
merged 3 commits into from
May 27, 2022
Merged

Update ELCA to leverage Ultranest verbosity controls #991

merged 3 commits into from
May 27, 2022

Conversation

jpl-jengelke
Copy link
Collaborator

@jpl-jengelke jpl-jengelke commented May 5, 2022 •
edited
Loading

  • Code formatting cleanup
  • Add verbosity flags to UN calls

Closes #982

@jpl-jengelke
Copy link
Collaborator Author

@pearsonkyle Please review carefully as changes were made to critical code. Although many changes were formatting related, the relevant commit is here.

Relevant lines are (latest): 311, 327, 656 and 737. Others are formatting related.

pearsonkyle
pearsonkyle approved these changes May 26, 2022
View reviewed changes
Copy link
Collaborator

@pearsonkyle pearsonkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just ran the branch with the dynesty code and the formatting is correct. I was able to make it through the sampling process.

@rzellem rzellem merged commit bbfa91e into develop May 27, 2022
@jpl-jengelke jpl-jengelke deleted the issue_982 branch May 31, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearsonkyle pearsonkyle pearsonkyle approved these changes

Assignees

@rzellem rzellem

@jpl-jengelke jpl-jengelke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpl-jengelke @pearsonkyle @rzellem