Issue 1125: Include AAVSO comparison stars as default during initialization file construction for Colab #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tars automatically from AAVSO as well as default demosaic parameters.
jpl-jengelke
approved these changes
Oct 17, 2024
|
|
||
| "Target Star X & Y Pixel": %s, | ||
| "Comparison Star(s) X & Y Pixel": %s | ||
| "Comparison Star(s) X & Y Pixel": %s, |
There was a problem hiding this comment.
This is a little clunky since some strings are surrounded with quotes and some are not. I see why and that it works (null being subbed into a multiline string) but it creates a disjoint appearance while reading code.
Just a comment on maintainable code, nothing to strictly fix here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing out the colab notebooks earlier and saw that it was prompting AAVSO comp stars from the command line. I also noticed it was an issue asking for the comparison stars to be default per issue #1125. I updated the construct of the file to conform to today's initialization file.
Please do not release this in v4.2. Save for 4.3 (next week).
Closes #1125