Issue 949: Mid-Transit Uncertainty limited by Orbital Period #1063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fitting for the optimal aperture sizes
|
@pearsonkyle - can you please review this one? you know better than I do about this clipping I think I originally made this issue because a user was finding that EXOTIC was latching on to the incorrect ephemeris due to their Tmid being so large...but I honestly forget. |
pearsonkyle
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it exists within the final fit (here), I also added it within
fit_lightcurve()when finding the optimal aperture/annulus size. Let me know if this change is necessary.Closes issue #949 nonetheless.