Skip to content

Issue 1058: Fixing variable star errors and filter query for VSP #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2022
Merged

Issue 1058: Fixing variable star errors and filter query for VSP #1059

merged 2 commits into from
Oct 14, 2022

Conversation

tamimfatahi
Copy link
Collaborator

  • EXOTIC should no longer error out when no comparison stars were gathered from AAVSO's VSP API
  • When users utilize the CV filter, it will get converted to V for the AAVSO query on finding mags of comp stars from VSP
  • When querying VSP, the image scale is now calculated rather than having a hardcoded value
  • Code cleanup, ex: numba entirely from code as it isn't being utilized for cleanup, small QOL changes

Closes issue #1058

@tamimfatahi
Fixed issues regarding variable star calculator as it errored out whe…
ec30b4c 
…n no comp stars were scraped from AAVSO. Converted CV -> V filter when scraping for comp stars. Also, added in calculator for chart scale as beforehand was a hardcoded value that can possibly run too small if images were of large FOVs.
@tamimfatahi
organized a bit
2a39de4
@pearsonkyle
Copy link
Collaborator

merge this first

@rzellem rzellem merged commit 38cec85 into develop Oct 14, 2022
@tamimfatahi tamimfatahi mentioned this pull request Oct 14, 2022
Closed
@tamimfatahi tamimfatahi deleted the issue_1058 branch October 29, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzellem rzellem rzellem approved these changes

@pearsonkyle pearsonkyle Awaiting requested review from pearsonkyle

@ihuckabee ihuckabee Awaiting requested review from ihuckabee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tamimfatahi @pearsonkyle @rzellem