-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds optional parameter quoteEmptyFields #97
base: master
Are you sure you want to change the base?
Conversation
+1 this would be very useful Full disclosure: The author of the MR and I work at the same company. |
@ryu1kn Is there anything else that should be done for this MR? |
+1 this would be indeed useful |
+1. I would like have this PR merged and released soon :-) |
+1 I'd love to keep using this package but I needed this functionality and ultimately couldn't get it here. I'll have to look elsewhere. Love the interface but it's missing important functionality and contributor presence. |
Hi @blowfishlol , I’ve forked the CSV Writer project since the original seems abandoned. Your work on the Check it out here: CSV Writer Portable. You’re credited in the commit messages. Thanks for your contribution! Best, |
+1 please merge this PR soon! |
This pull request takes the input stated in issue #60
with this PR,
createObjectCsvWriter
andcreateArrayCsvWriter
accepts the parameterquoteEmptyFields
, and this will any cause empty (null/undefined) values to be given an empty double quote (""
)The reason we needed this is that our company is working on the finance sector and one of the specification for the generated CSV files is for the nullish fields to be given an empty quote (""), and this PR makes it possible to configure the CSV writer to write nullish values as ("")
So
quoteEmptyFields
together with thealwaysQuote
param, with the input of:["VALUE_A, "VALUE_B", undefined, null]
Will generate an output:
"VALUE_A","VALUE_B","",""\n