Add PayloadDecodeException and DeviceInfoUnavailableException#685
Merged
Add PayloadDecodeException and DeviceInfoUnavailableException#685
Conversation
…bleException Enables better control of error cases for downstream users: * PayloadDecodeException gets raised if the payload cannot be decoded even after all quirks are tried * DeviceInfoUnavailable gets raised by Device.info() if decoding the miIO.info payload fails Related: home-assistant/core#34225
rytilahti
changed the title
rytilahti
changed the title
21 tasks
xvlady
pushed a commit
to xvlady/python-miio
that referenced
this pull request
May 9, 2021
…hti#685) * Add two new exceptions: PayloadDecodeException and DeviceInfoUnavailableException Enables better control of error cases for downstream users: * PayloadDecodeException gets raised if the payload cannot be decoded even after all quirks are tried * DeviceInfoUnavailable gets raised by Device.info() if decoding the miIO.info payload fails Related: home-assistant/core#34225 * add tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables better control of error cases for downstream users:
Related: home-assistant/core#34225