Skip to content

Moonlight: Provide property rgb as tuple#414

Merged
rytilahti merged 7 commits intorytilahti:masterfrom
syssi:feature/moonlight-return-rgb
Nov 18, 2018
Merged

Moonlight: Provide property rgb as tuple#414
rytilahti merged 7 commits intorytilahti:masterfrom
syssi:feature/moonlight-return-rgb

Conversation

@syssi
Copy link
Copy Markdown
Collaborator

@syssi syssi commented Nov 17, 2018

No description provided.

@syssi syssi changed the title Moonlight: Provide the rgb property as tuple Moonlight: Provide property rgb as tuple Nov 17, 2018
@syssi
Copy link
Copy Markdown
Collaborator Author

syssi commented Nov 17, 2018

May be set_rgb should be improved, too and we need a method per direction? Do you prefer a name? @rytilahti

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.1%) to 72.948% when pulling be7895a on syssi:feature/moonlight-return-rgb into 293c3a0 on rytilahti:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 17, 2018

Coverage Status

Coverage increased (+0.3%) to 73.117% when pulling 8fa7e2d on syssi:feature/moonlight-return-rgb into 293c3a0 on rytilahti:master.

@syssi syssi added this to the 0.4.4 milestone Nov 17, 2018
@rytilahti
Copy link
Copy Markdown
Owner

rytilahti commented Nov 17, 2018

I would say we want to have it both ways, maybe just int_to_rgb and rgb_to_int to do the conversions, and changing set_rgb to take a tuple as input?

@syssi
Copy link
Copy Markdown
Collaborator Author

syssi commented Nov 17, 2018

Alright. I will care about!

@syssi syssi closed this Nov 17, 2018
@syssi syssi reopened this Nov 17, 2018
@syssi
Copy link
Copy Markdown
Collaborator Author

syssi commented Nov 18, 2018

@rytilahti I'm done. :-)

@rytilahti
Copy link
Copy Markdown
Owner

Looking good! 👍

@rytilahti rytilahti merged commit 34c0223 into rytilahti:master Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants