Skip to content

Bump construct version (Closes: #374)#376

Closed
syssi wants to merge 1 commit intorytilahti:masterfrom
syssi:feature/update-construct
Closed

Bump construct version (Closes: #374)#376
syssi wants to merge 1 commit intorytilahti:masterfrom
syssi:feature/update-construct

Conversation

@syssi
Copy link
Copy Markdown
Collaborator

@syssi syssi commented Sep 2, 2018

No description provided.

@syssi
Copy link
Copy Markdown
Collaborator Author

syssi commented Sep 2, 2018

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 70.716% when pulling 300d046 on syssi:feature/update-construct into 11ea2a0 on rytilahti:master.

@fabaff
Copy link
Copy Markdown

fabaff commented Sep 2, 2018

The pinning should be removed or allow newer releases.

@fabaff
Copy link
Copy Markdown

fabaff commented Sep 20, 2018

Any progress on this?

@rytilahti
Copy link
Copy Markdown
Owner

I have not yet tested this, but assuming everything keeps still working I'm all for merging it. I'll do test my devices later this week, @syssi has apparently already verified that this is working with his.

@rytilahti
Copy link
Copy Markdown
Owner

I did a test with the most recent construct version and everything I have (vacuum, powerstrip) kept working, so I removed the pinning for the next release!

@syssi
Copy link
Copy Markdown
Collaborator Author

syssi commented Oct 7, 2018

Closing this because we dropped the pin. cp. #384

@syssi syssi closed this Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants